[PR #666] [MERGED] Check key for RSA header otherwise use EC, and output fix. #3282

New issue

Closed

opened 2026-02-26 07:38:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 07:38:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/666
Author: @MarceloLagos
Created: 10/18/2020
Status: ✅ Merged
Merged: 10/18/2020
Merged by: @jc21

Base: develop ← Head: master

📝 Commits (3)

301499d Merge pull request #659 from jc21/develop
7ba58bd Update certificate.js
190cd2d Update certificate.js

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 backend/internal/certificate.js (+4 -4)

📄 Description

Performing a check on the uploaded key looking for -----BEGIN RSA (should it be less specific like just BEGIN RSA?).
Then modify the openssl command to:

Use either rsa or ec to validate the key.
Sending standard error to standard output to catch all output (ec validation seems to send it to output error even when successful)

Finally modify the result verification by adding the string to be found on EC key validation (key valid) which is different than the one in RSA validation (key ok).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/666 **Author:** [@MarceloLagos](https://github.com/MarceloLagos) **Created:** 10/18/2020 **Status:** ✅ Merged **Merged:** 10/18/2020 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `master` --- ### 📝 Commits (3) - [`301499d`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/301499dc525d39f226b391fb88f28385ce0cb008) Merge pull request #659 from jc21/develop - [`7ba58bd`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/7ba58bdbd3d0667337fc1e48281828e49c0ec56b) Update certificate.js - [`190cd2d`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/190cd2d6bb48e63127d03f9dde070e0934f1919c) Update certificate.js ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/certificate.js` (+4 -4) </details> ### 📄 Description Performing a check on the uploaded key looking for `-----BEGIN RSA` (should it be less specific like just `BEGIN RSA`?). Then modify the openssl command to: 1. Use either `rsa` or `ec` to validate the key. 2. Sending standard error to standard output to catch all output (ec validation seems to send it to output error even when successful) Finally modify the result verification by adding the string to be found on EC key validation (`key valid`) which is different than the one in RSA validation (`key ok`). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 07:38:43 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3282

No description provided.

Rows
Columns