[PR #664] [MERGED] Adds certbot plugin installation check on startup #3280

Closed
opened 2026-02-26 07:38:43 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/664
Author: @chaptergy
Created: 10/17/2020
Status: Merged
Merged: 10/18/2020
Merged by: @jc21

Base: developHead: fixes-expiring-hosts-renewal


📝 Commits (2)

  • 1028de8 Adds certbot plugin installation check on startup
  • 08ab621 Fixes eslint errors

📊 Changes

4 files changed (+67 additions, -34 deletions)

View changed files

📝 backend/internal/certificate.js (+22 -31)
📝 backend/setup.js (+43 -1)
📝 frontend/js/i18n/messages.json (+1 -1)
📝 global/certbot-dns-plugins.js (+1 -1)

📄 Description

This PR fixes issue https://github.com/jc21/nginx-proxy-manager/issues/662. All necessary certbot plugins are installed on app startup and credentials are only deleted if the certificate is revoked.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/664 **Author:** [@chaptergy](https://github.com/chaptergy) **Created:** 10/17/2020 **Status:** ✅ Merged **Merged:** 10/18/2020 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `fixes-expiring-hosts-renewal` --- ### 📝 Commits (2) - [`1028de8`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/1028de8158a3e9396930c2e91d5862de5d7866ba) Adds certbot plugin installation check on startup - [`08ab621`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/08ab62108fb76d8e39e06be46fdc1604fb33c1e3) Fixes eslint errors ### 📊 Changes **4 files changed** (+67 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/certificate.js` (+22 -31) 📝 `backend/setup.js` (+43 -1) 📝 `frontend/js/i18n/messages.json` (+1 -1) 📝 `global/certbot-dns-plugins.js` (+1 -1) </details> ### 📄 Description This PR fixes issue https://github.com/jc21/nginx-proxy-manager/issues/662. All necessary certbot plugins are installed on app startup and credentials are only deleted if the certificate is revoked. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 07:38:43 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3280
No description provided.