mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-25 17:35:52 +03:00
[PR #664] [MERGED] Adds certbot plugin installation check on startup #3280
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#3280
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/664
Author: @chaptergy
Created: 10/17/2020
Status: ✅ Merged
Merged: 10/18/2020
Merged by: @jc21
Base:
develop← Head:fixes-expiring-hosts-renewal📝 Commits (2)
1028de8Adds certbot plugin installation check on startup08ab621Fixes eslint errors📊 Changes
4 files changed (+67 additions, -34 deletions)
View changed files
📝
backend/internal/certificate.js(+22 -31)📝
backend/setup.js(+43 -1)📝
frontend/js/i18n/messages.json(+1 -1)📝
global/certbot-dns-plugins.js(+1 -1)📄 Description
This PR fixes issue https://github.com/jc21/nginx-proxy-manager/issues/662. All necessary certbot plugins are installed on app startup and credentials are only deleted if the certificate is revoked.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.