[PR #656] [MERGED] Fixes custom certificate upload #3276

Closed
opened 2026-02-26 07:38:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/656
Author: @chaptergy
Created: 10/15/2020
Status: Merged
Merged: 10/15/2020
Merged by: @jc21

Base: developHead: fixes-custom-certificate-upload


📝 Commits (1)

  • 551a9fe Fixes custom certificate upload

📊 Changes

4 files changed (+47 additions, -48 deletions)

View changed files

📝 frontend/js/app/api.js (+7 -2)
📝 frontend/js/app/nginx/certificates/form.ejs (+2 -5)
📝 frontend/js/app/nginx/certificates/form.js (+37 -40)
📝 frontend/js/i18n/messages.json (+1 -1)

📄 Description

Unfortunately the custom certificate upload was broken since the introduction of the Cloudflare DNS challenge. See https://github.com/jc21/nginx-proxy-manager/issues/594. This pull request fixes those issues.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/656 **Author:** [@chaptergy](https://github.com/chaptergy) **Created:** 10/15/2020 **Status:** ✅ Merged **Merged:** 10/15/2020 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `fixes-custom-certificate-upload` --- ### 📝 Commits (1) - [`551a9fe`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/551a9fe1c6621e82e2832beeec46cfecfed63c0f) Fixes custom certificate upload ### 📊 Changes **4 files changed** (+47 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `frontend/js/app/api.js` (+7 -2) 📝 `frontend/js/app/nginx/certificates/form.ejs` (+2 -5) 📝 `frontend/js/app/nginx/certificates/form.js` (+37 -40) 📝 `frontend/js/i18n/messages.json` (+1 -1) </details> ### 📄 Description Unfortunately the custom certificate upload was broken since the introduction of the Cloudflare DNS challenge. See https://github.com/jc21/nginx-proxy-manager/issues/594. This pull request fixes those issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 07:38:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3276
No description provided.