[PR #635] [MERGED] Allow DNS challenges not just for cloudflare #3274

New issue

Closed

opened 2026-02-26 07:38:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 07:38:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/635
Author: @chaptergy
Created: 10/6/2020
Status: ✅ Merged
Merged: 10/14/2020
Merged by: @jc21

Base: develop ← Head: allow-more-dns-challenges

📝 Commits (10+)

28f7208 Merge pull request #592 from jc21/develop
b81325d Implements dns challenge provider selection in frontend
2523424 Updates dockerfiles
05f6a55 Adds frontend improvements and fixes
093b48a Implements backend changes to allow more dns challenges
64de36c Adds more DNS plugins
4cbc1f5 Minor refactoring
514b13f Fixes build issues due to globally used file
95208a5 Increases timeouts in front- and backend
867fe13 Unifies directory structure in dev and prod containers

📊 Changes

27 files changed (+1115 additions, -223 deletions)

View changed files

📝 Jenkinsfile (+1 -0)
📝 backend/app.js (+1 -1)
📝 backend/config/sqlite-test-db.json (+1 -1)
📝 backend/internal/certificate.js (+91 -30)
📝 backend/routes/api/nginx/certificates.js (+2 -0)
📝 backend/schema/endpoints/certificates.json (+14 -2)
📝 docker/Dockerfile (+3 -2)
📝 docker/dev/Dockerfile (+2 -2)
📝 docker/docker-compose.dev.yml (+12 -1)
📝 docker/rootfs/etc/nginx/conf.d/dev.conf (+3 -0)
📝 docker/rootfs/etc/nginx/conf.d/production.conf (+3 -0)
📝 docker/rootfs/etc/services.d/manager/run (+1 -1)
📝 frontend/js/app/api.js (+5 -4)
📝 frontend/js/app/nginx/certificates/form.ejs (+94 -11)
📝 frontend/js/app/nginx/certificates/form.js (+80 -29)
📝 frontend/js/app/nginx/certificates/list/item.ejs (+1 -1)
📝 frontend/js/app/nginx/certificates/list/item.js (+7 -5)
📝 frontend/js/app/nginx/dead/form.ejs (+84 -8)
📝 frontend/js/app/nginx/dead/form.js (+91 -34)
📝 frontend/js/app/nginx/proxy/form.ejs (+84 -8)

...and 7 more files

📄 Description

This merge request would allow way more providers for DNS challenges to request wildcard certificates, not just for Cloudflare users.
These new providers are collected in an easily maintainable list global/certbot-dns-plugins.js.

As a little bonus "Internal Errors" as thrown by the backend now show the stack of what exactly went wrong, so users can sort out some problems on their own. This was requested in issue https://github.com/jc21/nginx-proxy-manager/issues/627 as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/635 **Author:** [@chaptergy](https://github.com/chaptergy) **Created:** 10/6/2020 **Status:** ✅ Merged **Merged:** 10/14/2020 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `allow-more-dns-challenges` --- ### 📝 Commits (10+) - [`28f7208`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/28f72086ec2d8cd168fbf1aab99c770dfdc0f092) Merge pull request #592 from jc21/develop - [`b81325d`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/b81325d7bf4606a37b3c19a9ab2676c4b209e6ef) Implements dns challenge provider selection in frontend - [`2523424`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/2523424f682d5f1da5a28324277acd4c3f1abdb8) Updates dockerfiles - [`05f6a55`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/05f6a55a0b4e16e678e20c3b66588122d4c5669e) Adds frontend improvements and fixes - [`093b48a`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/093b48ad7b5417968d33ee3636e000bcc37f8795) Implements backend changes to allow more dns challenges - [`64de36c`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/64de36cdf27865eb342847e013d0c372405c939c) Adds more DNS plugins - [`4cbc1f5`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/4cbc1f5bbea2ac5dc1ad4b31639e2e2755c42e9d) Minor refactoring - [`514b13f`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/514b13fcc24fd07bcef6885bec40b9c169626597) Fixes build issues due to globally used file - [`95208a5`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/95208a50a742a40f4aba51b8d73433f7afd35327) Increases timeouts in front- and backend - [`867fe13`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/867fe1322bdca87929f6e74196d24605f2b170e8) Unifies directory structure in dev and prod containers ### 📊 Changes **27 files changed** (+1115 additions, -223 deletions) <details> <summary>View changed files</summary> 📝 `Jenkinsfile` (+1 -0) 📝 `backend/app.js` (+1 -1) 📝 `backend/config/sqlite-test-db.json` (+1 -1) 📝 `backend/internal/certificate.js` (+91 -30) 📝 `backend/routes/api/nginx/certificates.js` (+2 -0) 📝 `backend/schema/endpoints/certificates.json` (+14 -2) 📝 `docker/Dockerfile` (+3 -2) 📝 `docker/dev/Dockerfile` (+2 -2) 📝 `docker/docker-compose.dev.yml` (+12 -1) 📝 `docker/rootfs/etc/nginx/conf.d/dev.conf` (+3 -0) 📝 `docker/rootfs/etc/nginx/conf.d/production.conf` (+3 -0) 📝 `docker/rootfs/etc/services.d/manager/run` (+1 -1) 📝 `frontend/js/app/api.js` (+5 -4) 📝 `frontend/js/app/nginx/certificates/form.ejs` (+94 -11) 📝 `frontend/js/app/nginx/certificates/form.js` (+80 -29) 📝 `frontend/js/app/nginx/certificates/list/item.ejs` (+1 -1) 📝 `frontend/js/app/nginx/certificates/list/item.js` (+7 -5) 📝 `frontend/js/app/nginx/dead/form.ejs` (+84 -8) 📝 `frontend/js/app/nginx/dead/form.js` (+91 -34) 📝 `frontend/js/app/nginx/proxy/form.ejs` (+84 -8) _...and 7 more files_ </details> ### 📄 Description This merge request would allow way more providers for DNS challenges to request wildcard certificates, not just for Cloudflare users. These new providers are collected in an easily maintainable list `global/certbot-dns-plugins.js`. As a little bonus "Internal Errors" as thrown by the backend now show the stack of what exactly went wrong, so users can sort out some problems on their own. This was requested in issue https://github.com/jc21/nginx-proxy-manager/issues/627 as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 07:38:42 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3274

No description provided.

Rows
Columns