[PR #559] [MERGED] Removed the hardcoded --webroot certbot argument to better support DNS challenge #3265

Closed
opened 2026-02-26 07:38:40 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/559
Author: @jlesage
Created: 8/14/2020
Status: Merged
Merged: 8/24/2020
Merged by: @jc21

Base: developHead: remove-webroot-certbot-arg


📝 Commits (1)

  • f539e81 Removed the hardcoded --webroot certbot argument to better support DNS challenge. Also, this option is already set in the default letsencrypt.ini.

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 backend/internal/certificate.js (+0 -1)

📄 Description

Also, note that this option is already set in the default letsencrypt.ini.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/559 **Author:** [@jlesage](https://github.com/jlesage) **Created:** 8/14/2020 **Status:** ✅ Merged **Merged:** 8/24/2020 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `remove-webroot-certbot-arg` --- ### 📝 Commits (1) - [`f539e81`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/f539e813aafc997d52633dc17ee7a4f9c828b8a3) Removed the hardcoded `--webroot` certbot argument to better support DNS challenge. Also, this option is already set in the default `letsencrypt.ini`. ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/certificate.js` (+0 -1) </details> ### 📄 Description Also, note that this option is already set in the default `letsencrypt.ini`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 07:38:40 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3265
No description provided.