[PR #510] [MERGED] Multidb - sqlite support #3251

New issue

Closed

opened 2026-02-26 07:38:37 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 07:38:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/510
Author: @tg44
Created: 7/19/2020
Status: ✅ Merged
Merged: 8/5/2020
Merged by: @jc21

Base: develop ← Head: multidb-re

📝 Commits (3)

f8edeb2 fixed migration and setup
a9e7222 introduced now_helper for multidb capabilities
6690b77 sqlite3 and psql support

📊 Changes

19 files changed (+365 additions, -156 deletions)

View changed files

➕ backend/config/sqlite-test-db.json (+26 -0)
📝 backend/db.js (+21 -13)
📝 backend/migrations/20190227065017_settings.js (+0 -16)
📝 backend/models/access_list.js (+4 -3)
📝 backend/models/access_list_auth.js (+4 -3)
📝 backend/models/access_list_client.js (+4 -3)
📝 backend/models/audit-log.js (+4 -3)
📝 backend/models/auth.js (+4 -3)
📝 backend/models/certificate.js (+5 -4)
📝 backend/models/dead_host.js (+4 -3)
➕ backend/models/now_helper.js (+13 -0)
📝 backend/models/proxy_host.js (+4 -3)
📝 backend/models/redirection_host.js (+4 -3)
📝 backend/models/stream.js (+4 -3)
📝 backend/models/user.js (+4 -3)
📝 backend/models/user_permission.js (+4 -3)
📝 backend/package.json (+2 -0)
📝 backend/setup.js (+122 -88)
📝 backend/yarn.lock (+132 -2)

📄 Description

I recreated this PR; https://github.com/jc21/nginx-proxy-manager/pull/256

Separated commits;

The first solves the ~~transaction in transaction~~ connection in connection problem in the migration, which causes problems on db-engines which has no multithread support (like sqlite3), also adds a minor refactor to the setup.js
The second adds a helper to the 'NOW()' sql function, bcs some db engines (like sqlite) has another syntax for this...
The third adds a new db-config option (knex-native) and let an experienced knex user to add some own knex-native configurations. Also, this commit showcases an sqlite3 config, and adds psql and sqlite3 libs.

Probably fixes #185 and fixes #200

Missing things;

document the sqlite config
try out the psql support

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/510 **Author:** [@tg44](https://github.com/tg44) **Created:** 7/19/2020 **Status:** ✅ Merged **Merged:** 8/5/2020 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `multidb-re` --- ### 📝 Commits (3) - [`f8edeb2`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/f8edeb2775c7219a4b05d84de7e6848f13d17257) fixed migration and setup - [`a9e7222`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/a9e7222e5e1b1b1458efc7628a87bf04d426b522) introduced now_helper for multidb capabilities - [`6690b77`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/6690b7735d494820a7c0fa243dda86157bceb282) sqlite3 and psql support ### 📊 Changes **19 files changed** (+365 additions, -156 deletions) <details> <summary>View changed files</summary> ➕ `backend/config/sqlite-test-db.json` (+26 -0) 📝 `backend/db.js` (+21 -13) 📝 `backend/migrations/20190227065017_settings.js` (+0 -16) 📝 `backend/models/access_list.js` (+4 -3) 📝 `backend/models/access_list_auth.js` (+4 -3) 📝 `backend/models/access_list_client.js` (+4 -3) 📝 `backend/models/audit-log.js` (+4 -3) 📝 `backend/models/auth.js` (+4 -3) 📝 `backend/models/certificate.js` (+5 -4) 📝 `backend/models/dead_host.js` (+4 -3) ➕ `backend/models/now_helper.js` (+13 -0) 📝 `backend/models/proxy_host.js` (+4 -3) 📝 `backend/models/redirection_host.js` (+4 -3) 📝 `backend/models/stream.js` (+4 -3) 📝 `backend/models/user.js` (+4 -3) 📝 `backend/models/user_permission.js` (+4 -3) 📝 `backend/package.json` (+2 -0) 📝 `backend/setup.js` (+122 -88) 📝 `backend/yarn.lock` (+132 -2) </details> ### 📄 Description I recreated this PR; https://github.com/jc21/nginx-proxy-manager/pull/256 Separated commits; - The first solves the ~~transaction in transaction~~ connection in connection problem in the migration, which causes problems on db-engines which has no multithread support (like sqlite3), also adds a minor refactor to the setup.js - The second adds a helper to the 'NOW()' sql function, bcs some db engines (like sqlite) has another syntax for this... - The third adds a new db-config option (`knex-native`) and let an experienced knex user to add some own knex-native configurations. Also, this commit showcases an sqlite3 config, and adds psql and sqlite3 libs. Probably fixes #185 and fixes #200 Missing things; - document the sqlite config - try out the psql support --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 07:38:37 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3251

No description provided.

Rows
Columns