[PR #435] [MERGED] Don't use duplicate relations when eager-loading access list items and clients. #3246

New issue

Closed

opened 2026-02-26 07:38:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 07:38:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/435
Author: @Subv
Created: 5/30/2020
Status: ✅ Merged
Merged: 6/2/2020
Merged by: @jc21

Base: develop ← Head: access_lists_ips

📝 Commits (2)

546f862 Merge pull request #429 from jc21/develop
d95861e Don't use duplicate relations when eager-loading access list items and clients.

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 backend/internal/access-list.js (+3 -3)
📝 backend/internal/proxy-host.js (+3 -3)

📄 Description

This fixes an Objection warning: Duplicate relation "proxy_hosts" in a relation expression. You should use "a.[b, c]" instead of "[a.b, a.c]". This will cause an error in objection 2.0.

It also fixes the access list clients not being properly eager-loaded when building the proxy host nginx configuration files, resulting in no IP access lists being printed into the file.

Closes #434

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/435 **Author:** [@Subv](https://github.com/Subv) **Created:** 5/30/2020 **Status:** ✅ Merged **Merged:** 6/2/2020 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `access_lists_ips` --- ### 📝 Commits (2) - [`546f862`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/546f8622360747e85ec07306ddf7ec0eef35e177) Merge pull request #429 from jc21/develop - [`d95861e`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/d95861e1fb1862ec55c059df9e8790f469ae74c0) Don't use duplicate relations when eager-loading access list items and clients. ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/internal/access-list.js` (+3 -3) 📝 `backend/internal/proxy-host.js` (+3 -3) </details> ### 📄 Description This fixes an Objection warning: `Duplicate relation "proxy_hosts" in a relation expression. You should use "a.[b, c]" instead of "[a.b, a.c]". This will cause an error in objection 2.0`. It also fixes the access list clients not being properly eager-loaded when building the proxy host nginx configuration files, resulting in no IP access lists being printed into the file. Closes #434 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 07:38:36 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3246

No description provided.

Rows
Columns