mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-25 17:35:52 +03:00
[PR #406] [MERGED] set proper timeout. #3241
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#3241
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/406
Author: @theraw
Created: 5/10/2020
Status: ✅ Merged
Merged: 5/25/2020
Merged by: @jc21
Base:
develop← Head:patch-1📝 Commits (1)
affabf0set proper timeout.📊 Changes
1 file changed (+5 additions, -2 deletions)
View changed files
📝
docker/rootfs/etc/nginx/nginx.conf(+5 -2)📄 Description
it makes so nginx can handle connection client <- nginx -> backend for 90 secounds (90s i think is normal and most used timeout limit)
Example if you for backend have apache2 and your timeout is 300s and you try to install some script that take longer then 65s (current conf https://github.com/jc21/nginx-proxy-manager/blob/master/docker/rootfs/etc/nginx/nginx.conf#L29) then nginx will close connection at 65s ignoring apache (backend) 300s timeout and will return 504 err.
server_names_hash_bucket_size 64;->server_names_hash_bucket_size 1024;will increase support for long sub-domain names http://nginx.org/en/docs/http/server_names.html current 64 i think is low🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.