[PR #376] [MERGED] expand the maximum size of the forward_host #3235

Closed
opened 2026-02-26 07:38:34 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/376
Author: @spalger
Created: 4/16/2020
Status: Merged
Merged: 4/16/2020
Merged by: @jc21

Base: developHead: expand-forward-host-size


📝 Commits (4)

  • 4c60bfb Merge pull request #370 from jc21/develop
  • 995db12 remove arbitrary length limit of forward_host
  • 1d23d5c remove maxlength from html too
  • 3af560c switch to 255 limit to match db

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 backend/schema/endpoints/proxy-hosts.json (+1 -1)
📝 frontend/js/app/nginx/proxy/form.ejs (+1 -1)

📄 Description

I'm trying to setup a proxy host to a hostname that is 56 characters long and that's not allowed by the schema for the proxy host for some reason :/ I think it's probably best to avoid arbitrary limits like this so I've removed it from the schema, but I could also set it to 255 or something if you prefer.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/376 **Author:** [@spalger](https://github.com/spalger) **Created:** 4/16/2020 **Status:** ✅ Merged **Merged:** 4/16/2020 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `expand-forward-host-size` --- ### 📝 Commits (4) - [`4c60bfb`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/4c60bfb66bae09ae5d3edb930fbd414232951261) Merge pull request #370 from jc21/develop - [`995db12`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/995db12f224b9645783c6db530e2da421e310758) remove arbitrary length limit of forward_host - [`1d23d5c`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/1d23d5c7613e9282fcb3953001b92bf53457f01d) remove maxlength from html too - [`3af560c`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/3af560c2d0c08f8a06e3ad870fa938859fb43ea6) switch to 255 limit to match db ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/schema/endpoints/proxy-hosts.json` (+1 -1) 📝 `frontend/js/app/nginx/proxy/form.ejs` (+1 -1) </details> ### 📄 Description I'm trying to setup a proxy host to a hostname that is 56 characters long and that's not allowed by the schema for the proxy host for some reason :/ I think it's probably best to avoid arbitrary limits like this so I've removed it from the schema, but I could also set it to 255 or something if you prefer. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 07:38:34 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3235
No description provided.