[PR #189] [MERGED] Selection of the ssl protocols/ciphers is done using the default sever block #3201

Closed
opened 2026-02-26 07:38:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/189
Author: @jlesage
Created: 8/20/2019
Status: Merged
Merged: 8/21/2019
Merged by: @jc21

Base: developHead: ssl-fix


📝 Commits (2)

  • 0d5a232 Selection of the ssl protocols/ciphers is done using the default server block.
  • dfc6d91 Merge branch 'develop' into ssl-fix

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 rootfs/etc/nginx/conf.d/default.conf (+1 -1)

📄 Description

The check for allowed SSL protocols is done before SNI, thus the default server block is always used.

See https://www.ruby-forum.com/t/ssl-protocols-per-server/232557/11


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/189 **Author:** [@jlesage](https://github.com/jlesage) **Created:** 8/20/2019 **Status:** ✅ Merged **Merged:** 8/21/2019 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `ssl-fix` --- ### 📝 Commits (2) - [`0d5a232`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/0d5a232d00335954383a2cfa1b29944723b6a2de) Selection of the ssl protocols/ciphers is done using the default server block. - [`dfc6d91`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/dfc6d91962a1fe38999f7f875f5e05ce581fd4e5) Merge branch 'develop' into ssl-fix ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `rootfs/etc/nginx/conf.d/default.conf` (+1 -1) </details> ### 📄 Description The check for allowed SSL protocols is done before SNI, thus the default server block is always used. See https://www.ruby-forum.com/t/ssl-protocols-per-server/232557/11 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 07:38:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3201
No description provided.