[PR #165] [MERGED] Open up lets Encrypt acme challenge config #3199

Closed
opened 2026-02-26 07:38:26 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/165
Author: @the1ts
Created: 7/4/2019
Status: Merged
Merged: 7/4/2019
Merged by: @jc21

Base: masterHead: patch-1


📝 Commits (1)

  • c4b5420 Open up lets Encrypt acme challenge config

📊 Changes

1 file changed (+3 additions, -0 deletions)

View changed files

📝 rootfs/etc/nginx/conf.d/include/letsencrypt-acme-challenge.conf (+3 -0)

📄 Description

As discussed in Issue #135. Since Lets Encrypt don't publish IP ranges that their acme challenge service will be sourced from, we need to allow free access to this location special to override any IP ACLs added by Advanced Custom Nginx Configuration. Due to the way Nginx config is applied, this only applies to the regex and below, keeping the IP ACLs working for the rest of the website.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/165 **Author:** [@the1ts](https://github.com/the1ts) **Created:** 7/4/2019 **Status:** ✅ Merged **Merged:** 7/4/2019 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`c4b5420`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/c4b5420e768c10cc9fcabd8c7311b94f0206aeb1) Open up lets Encrypt acme challenge config ### 📊 Changes **1 file changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `rootfs/etc/nginx/conf.d/include/letsencrypt-acme-challenge.conf` (+3 -0) </details> ### 📄 Description As discussed in Issue #135. Since Lets Encrypt don't publish IP ranges that their acme challenge service will be sourced from, we need to allow free access to this location special to override any IP ACLs added by Advanced Custom Nginx Configuration. Due to the way Nginx config is applied, this only applies to the regex and below, keeping the IP ACLs working for the rest of the website. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 07:38:26 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#3199
No description provided.