mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-25 09:25:55 +03:00
[PR #165] [MERGED] Open up lets Encrypt acme challenge config #3199
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#3199
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/165
Author: @the1ts
Created: 7/4/2019
Status: ✅ Merged
Merged: 7/4/2019
Merged by: @jc21
Base:
master← Head:patch-1📝 Commits (1)
c4b5420Open up lets Encrypt acme challenge config📊 Changes
1 file changed (+3 additions, -0 deletions)
View changed files
📝
rootfs/etc/nginx/conf.d/include/letsencrypt-acme-challenge.conf(+3 -0)📄 Description
As discussed in Issue #135. Since Lets Encrypt don't publish IP ranges that their acme challenge service will be sourced from, we need to allow free access to this location special to override any IP ACLs added by Advanced Custom Nginx Configuration. Due to the way Nginx config is applied, this only applies to the regex and below, keeping the IP ACLs working for the rest of the website.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.