[PR #79] [MERGED] Ignore default location when defined in advanced config #3185

New issue

Closed

opened 2026-02-26 07:38:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 07:38:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/79
Author: @jc21
Created: 2/21/2019
Status: ✅ Merged
Merged: 2/25/2019
Merged by: @jc21

Base: develop ← Head: feature/65-advanced_default_location

📝 Commits (1)

a733c6d Ignore default location when defined in advanced config

📊 Changes

5 files changed (+31 additions, -3 deletions)

View changed files

📝 src/backend/internal/nginx.js (+16 -3)
📝 src/backend/templates/dead_host.conf (+3 -0)
📝 src/backend/templates/proxy_host.conf (+3 -0)
📝 src/backend/templates/redirection_host.conf (+3 -0)
📝 src/frontend/js/app/nginx/proxy/form.ejs (+6 -0)

📄 Description

Fixes #65 by ignoring the built-in default location when it's detected in the advanced configuration.

In essence, the regex searches for location / { in many forms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/79 **Author:** [@jc21](https://github.com/jc21) **Created:** 2/21/2019 **Status:** ✅ Merged **Merged:** 2/25/2019 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `develop` ← **Head:** `feature/65-advanced_default_location` --- ### 📝 Commits (1) - [`a733c6d`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/a733c6d3b662e14a62cf2dd69a7697de35e4815c) Ignore default location when defined in advanced config ### 📊 Changes **5 files changed** (+31 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/backend/internal/nginx.js` (+16 -3) 📝 `src/backend/templates/dead_host.conf` (+3 -0) 📝 `src/backend/templates/proxy_host.conf` (+3 -0) 📝 `src/backend/templates/redirection_host.conf` (+3 -0) 📝 `src/frontend/js/app/nginx/proxy/form.ejs` (+6 -0) </details> ### 📄 Description Fixes #65 by ignoring the built-in default location when it's detected in the advanced configuration. In essence, the regex searches for `location / {` in many forms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 07:38:22 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3185

No description provided.

Rows
Columns