[PR #23] [MERGED] Added default HTTPs site. #3178

New issue

Closed

opened 2026-02-26 07:38:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 07:38:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/23
Author: @jlesage
Created: 11/2/2018
Status: ✅ Merged
Merged: 11/4/2018
Merged by: @jc21

Base: master ← Head: default-https-site

📝 Commits (1)

20fd185 Added default HTTPs site.

📊 Changes

2 files changed (+28 additions, -0 deletions)

View changed files

📝 rootfs/etc/nginx/conf.d/default.conf (+14 -0)
📝 rootfs/etc/services.d/nginx/run (+14 -0)

📄 Description

Without a default site for HTTPs, another configured host will be wrongly used.

For example, when trying to access, via HTTP, a host that has not been setup yet, we get the "Congratulations" page as expected. However, doing the same via HTTPs does't show this default page, but shows a configured proxy host (for which SSL is enabled).

The same issue happen when configuring a host without enabling SSL: Access the host over HTTP works fine, but accessing the same host via HTTPs will show the page associated to another configured host.

Since there is no certificate associated to the default site, its configuration only return the special code 444, which makes nginx to close the connection.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NginxProxyManager/nginx-proxy-manager/pull/23 **Author:** [@jlesage](https://github.com/jlesage) **Created:** 11/2/2018 **Status:** ✅ Merged **Merged:** 11/4/2018 **Merged by:** [@jc21](https://github.com/jc21) **Base:** `master` ← **Head:** `default-https-site` --- ### 📝 Commits (1) - [`20fd185`](https://github.com/NginxProxyManager/nginx-proxy-manager/commit/20fd185652151546d7a13875a050ab5f6527cca6) Added default HTTPs site. ### 📊 Changes **2 files changed** (+28 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `rootfs/etc/nginx/conf.d/default.conf` (+14 -0) 📝 `rootfs/etc/services.d/nginx/run` (+14 -0) </details> ### 📄 Description Without a default site for HTTPs, another configured host will be wrongly used. For example, when trying to access, via HTTP, a host that has not been setup yet, we get the "Congratulations" page as expected. However, doing the same via HTTPs does't show this default page, but shows a configured proxy host (for which SSL is enabled). The same issue happen when configuring a host without enabling SSL: Access the host over HTTP works fine, but accessing the same host via HTTPs will show the page associated to another configured host. Since there is no certificate associated to the default site, its configuration only return the special code `444`, which makes nginx to close the connection. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 07:38:21 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#3178

No description provided.

Rows
Columns