mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-25 17:35:52 +03:00
[GH-ISSUE #371] Address already in use after update #315
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#315
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Thijmen on GitHub (Apr 15, 2020).
Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/371
Hi all,
I am running this fantastic tool for a while. I want to update to the latest image, because of #356 (which got merged recently 🥳 ).
This is the error I get:
I used
docker-compose pulland I was under the impression that it would be an easy upgrade. I triedjc21/nginx-proxy-manager:2andjc21/nginx-proxy-manager:latestIs there any way I can help debug this?
@Thijmen commented on GitHub (Apr 15, 2020):
Nevermind, I found it. Apparently the newer version binds to port
3000, and I am also proxy'ing a port 3000. Solved!@Thijmen commented on GitHub (Apr 15, 2020):
In hindsight, it would be nice if
github.com/jc21/nginx-proxy-manager@bb0f4bfa62/backend/index.js (L24)was an env-variable. Maybe I'll contribute that in the future!@jc21 commented on GitHub (Apr 15, 2020):
Well no it doesn't matter what port the backend binds to inside of it's own network. It matters to you, what port you expose to your host that maps to the container ports.
If you are seeing a port already in use problem, I can only assume you're running this container in a shared docker network with another service. 3000 is not even exposed in the Dockerfile so my previous statement wouldn't even be a problem either :/
@Thijmen commented on GitHub (Apr 16, 2020):
No, but if I already use port 3000 for nginx (streaming ports), it makes sense :) The message came from the container, not the host.
@jc21 commented on GitHub (Apr 16, 2020):
Ah yes of course
@Thijmen commented on GitHub (Apr 16, 2020):
How do you feel about making it an ENV-var, @jc21 ?
@jc21 commented on GitHub (Apr 16, 2020):
I feel uneasy about it. The backend api can listen on any port easy enough with a env var deciding what that port is. But, the Nginx configuration forwards requests from the Admin UI to the API with
127.0.0.1:3000and that would need to be dynamic as well.@jc21 commented on GitHub (Apr 16, 2020):
As a workaround for yourself, you can map ports in your docker-compose file
3000:3001and then set up a stream for3001to forward wherever you like.@Thijmen commented on GitHub (Apr 17, 2020):
Hmm yes, did not think of that, good point @jc21. I changed my infrastructure to adapt with the change anyway.