mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-25 17:35:52 +03:00
[GH-ISSUE #4088] satisfy_any toggle not working #2657
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#2657
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mikeymasonic on GitHub (Oct 19, 2024).
Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/4088
Checklist
jc21/nginx-proxy-manager:latestdocker image?Describe the bug
Whenever I set "Satisfy Any" in an access list details section, it doesn't work. For instance if I have an HTTP Auth setup and an IP route, if I access that particular proxy on a whitelisted IP, I get prompted for HTTP authentication. If I go to the proxy with a non whitelisted IP, I get 403 Forbidden and no HTTP Auth prompt. The check box does save the previous saved state however.
I've taken a look at the config files and I notice this near the end:
If I manually change this to
satisfy any;, everything works as expected.Another unrelated issue, I notice in the GUI I'm on version v2.12.1, but in my docker instance I see:
NPM_BUILD_VERSION | 2.11.3If I login to my docker container I see:
Version 2.11.3 (35d7a3a) 2024-07-01 11:42:06 UTCI've pulled the latest image several times.
Nginx Proxy Manager Version
v2.12.1
To Reproduce
Steps to reproduce the behavior:
Satisfy Anyis checkedsatisfy all;tosatisfy any;, everything works as expectedExpected behavior
Screenshots
Operating System
Using a docker instance on Ubuntu
Additional context
@binary-person commented on GitHub (Oct 23, 2024):
it seems that rolling back to "2.11.3" fixes it, but updating it to "2.12.0" and "2.12.1" breaks it
@Gabri3lZ commented on GitHub (Oct 23, 2024):
It looks like the commit
4572b205c9changed some model types from integer to boolean (one of them is the satisfy_any field). But the evaluation still checks for "satisfy_any == 1".I don't know if this is the only case the evaluation does not match the model type anymore though.
@Gabri3lZ commented on GitHub (Oct 25, 2024):
Should be fixed by
dad8d0cfrom @chrismaffey@bill340 commented on GitHub (Oct 27, 2024):
satisfy any is always overwritten to satisfy all in the .conf file after restarting the Nginx container.
So the toggle in the GUI and also what I write in the .conf file is not used, but overwritten again...
@allenwakeup commented on GitHub (Nov 5, 2024):
/backend/templates/_access.conf (line 20)
change from
{% if access_list.satisfy_any == 1 %}
to
{% if access_list.satisfy_any == 1 or access_list.satisfy_any == true %}
docker v2.12.1
@ghisch commented on GitHub (Nov 5, 2024):
You can temporarily use
nginxproxymanager/nginx-proxy-manager-dev:pr-4107as it was fixed 2W ago in https://github.com/NginxProxyManager/nginx-proxy-manager/pull/4107.Should be fixed in next release I guess.
@deluxestyle commented on GitHub (Dec 17, 2024):
is there any update on this?
already looking for alternatives as I don't get the developer build running
@mikeymasonic commented on GitHub (Dec 17, 2024):
@deluxestyle, I tried with the latest developer build as it shows that the PR has been merged, I use this with docker:
nginxproxymanager/nginx-proxy-manager-dev:latestto pull the image. That said, it still doesn't work for me 🫠 .Here is a script I wrote you can run on whatever machine hosts your docker instance, it changes anything that says
satisfy alltosatisfy anyin theproxy_host/*.confsection. I just run this whenever I have to make a change, it's annoying but it works.Hope this is helpful while we wait!
@Percy2Live commented on GitHub (Dec 30, 2024):
This seems to be fixed with 2.12.2
@FaySmash commented on GitHub (Jan 4, 2025):
I can confirm that it is fixed in 2.12.2
@vorwd commented on GitHub (Jan 6, 2025):
confirmed 2.12.2 fixes.
@mgeha commented on GitHub (Jan 21, 2025):
2.12.2 fixes it here as well.
@mikeymasonic commented on GitHub (Jan 21, 2025):
Fixed in 2.12.2!