mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-25 09:25:55 +03:00
[GH-ISSUE #279] JWT Token expiration #249
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#249
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dejecj on GitHub (Jan 26, 2020).
Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/279
I have a question about the access tokens issued by the api. It doesn't seem like they expire. Is this right? I am trying to integrate the manager into my own web app to seamlessly add hosts and generate SSLs but I can't figure out how to get the token to issue with an expiration from the REST endpoint "/token". The payload contains a secret and identity property and tried adding the "expiry" property which returns an "expires" property with the value I would expect but the token keeps functioning after that expires date has passed.
I know this might me outside the scope of how you want the manager to be used but it would be a great help if someone could point me in the right direction. Thanks.
@jc21 commented on GitHub (Jan 27, 2020):
I just inspected my JWT and there should have been an expiration time on it - and it's gone. I'll have to look in to this further.
@dejecj commented on GitHub (Jan 27, 2020):
@jc21 Ok thanks, I'll also look at the source and I'll let you know if I see anything.
@dejecj commented on GitHub (Jan 28, 2020):
@jc21 I think I found the issue, It looks like the token model's create method is expecting the second parameter to have an object with a property called expires but it's actually receiving an object with a property called expiresIn from the method getTokenFromEmail
@jc21 commented on GitHub (Jan 29, 2020):
Awesome work. I'll get that fixed soon