starred/nginx-proxy-manager-NginxProxyManager

Fork 0

mirror of https://github.com/NginxProxyManager/nginx-proxy-manager.git synced 2026-04-25 01:15:51 +03:00

[GH-ISSUE #3577] Access list working only with "manual" workarounds #2376

New issue

Open

opened 2026-02-26 07:35:18 +03:00 by kerem · 8 comments

kerem commented

2026-02-26 07:35:18 +03:00

Owner

Originally created by @hans-holgersson on GitHub (Feb 22, 2024).
Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/3577

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?
- Yes
Are you sure you're not using someone else's docker image?
- Yes
Have you searched for similar issues (both open and closed)?
- Yes

Describe the bug
Proxy hosts with attached ACLs has strange bahaviour, more exactly ACLs does not work as expected;
I will describe two stirngs of steps, because i think the two has common root cuse

Nginx Proxy Manager Version
v2.11.1

To Reproduce
Steps to reproduce the behavior #1:

create proxy host HOST1
create an ACL
attach ACL to HOST1
disable HOST1
proxy host config is deleted
enable proxy host
proxy host config is created, but it is incorrect, it has a location statement in it like this:

location / {
  # Access Rules: 0 total
  deny all;
  # Access checks must...
  satisfy all;

(satisfy statement has the value as it was set ACL)
8. because of the incorrect location the proxy host does not work - getting error 403;

9.1. open edit Proxy Host and simply save it, without any changes, the location statement is written correctly and proxy host works as expected;

9.2. open edit ACL, and simply save it, without any changes, the location statement is written correctly but poxy host does not work correctly because nginx does not pick up the new config: it must be restarted for example with a killall in container console.

Steps to reproduce the behavior #2:

create proxy host (say HOST1)
create ACL (say ACL1)
attach ACL1 to HOST1
disable proxy host HOST1
proxy host config for HOST1 is deleted
nginx is restarted automatically
6.1 HOST1 is not working in browser (it is OK because we disabled it, right?)
open to edit ACL1 and simply save it whithout any modification
proxy host config for HOST1 is generated
nginx is not restarted (HOST1 still not working in browser - it is OK until now)
open to edit some another proxy host (say HOST2), and save it
nginx will be restarted
HOST1 is working in browser (it is NOT OK!!! HOST1 is disabled - see step 4.) because of the existence of the previously generated config file (see setp 8.)

Expected behavior
The logic behind the actions generating config files for proxy hosts and reloading nginx should be correlated:

if proxy host is modified or edited (and saved) should take in account the attached ACLs too when generating config file;
if ACL is edited and saved it should take in account the status of the proxy hosts to which the ALC is attached, and if any real modifcation happned, nginx should be reloaded;

Screenshots

Operating System
Rocky Linux 9.3

Additional context
browser cache was cleared before single every test step

Originally created by @hans-holgersson on GitHub (Feb 22, 2024). Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/3577 **Checklist** - Have you pulled and found the error with `jc21/nginx-proxy-manager:latest` docker image? - Yes - Are you sure you're not using someone else's docker image? - Yes - Have you searched for similar issues (both open and closed)? - Yes **Describe the bug** Proxy hosts with attached ACLs has strange bahaviour, more exactly ACLs does not work as expected; I will describe two stirngs of steps, because i think the two has common root cuse **Nginx Proxy Manager Version** v2.11.1 **To Reproduce** Steps to reproduce the behavior #1: 1. create proxy host HOST1 2. create an ACL 3. attach ACL to HOST1 4. disable HOST1 5. proxy host config is deleted 6. enable proxy host 7. proxy host config is created, but it is incorrect, it has a location statement in it like this: ``` location / { # Access Rules: 0 total deny all; # Access checks must... satisfy all; ``` (satisfy statement has the value as it was set ACL) 8. because of the incorrect location the proxy host does not work - getting error 403; 9.1. open edit Proxy Host and simply save it, without any changes, the location statement is written correctly and proxy host works as expected; 9.2. open edit ACL, and simply save it, without any changes, the location statement is written correctly but poxy host does not work correctly because nginx does not pick up the new config: it must be restarted for example with a killall in container console. Steps to reproduce the behavior #2: 1. create proxy host (say HOST1) 2. create ACL (say ACL1) 3. attach ACL1 to HOST1 4. disable proxy host HOST1 5. proxy host config for HOST1 is deleted 6. nginx is restarted automatically 6.1 HOST1 is not working in browser (it is OK because we disabled it, right?) 7. open to edit ACL1 and simply save it whithout any modification 8. proxy host config for HOST1 is generated 9. nginx is not restarted (HOST1 still not working in browser - it is OK until now) 10. open to edit some another proxy host (say HOST2), and save it 11. nginx will be restarted 12. HOST1 is working in browser (it is NOT OK!!! HOST1 is disabled - see step 4.) because of the existence of the previously generated config file (see setp 8.) **Expected behavior** The logic behind the actions generating config files for proxy hosts and reloading nginx should be correlated: - if proxy host is modified or edited (and saved) should take in account the attached ACLs too when generating config file; - if ACL is edited and saved it should take in account the status of the proxy hosts to which the ALC is attached, and if any real modifcation happned, nginx should be reloaded; **Screenshots**  **Operating System** Rocky Linux 9.3 **Additional context** browser cache was cleared before single every test step

kerem added the

stale

bug

labels

2026-02-26 07:35:18 +03:00

kerem commented

2026-02-26 07:35:19 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Sep 3, 2024):

Issue is now considered stale. If you want to keep it open, please comment 👍

@github-actions[bot] commented on GitHub (Sep 3, 2024): Issue is now considered stale. If you want to keep it open, please comment :+1:

kerem commented

2026-02-26 07:35:19 +03:00

Author

Owner

@hans-holgersson commented on GitHub (Sep 3, 2024):

Is this resolved in the current "latest"?

@hans-holgersson commented on GitHub (Sep 3, 2024): Is this resolved in the current "latest"?

kerem commented

2026-02-26 07:35:19 +03:00

Author

Owner

@zhouguiheng commented on GitHub (Jan 8, 2025):

I encountered the same issue, and had to do step 9.1 to bring the host back.
I set up a new container from scratch for testing, and can consistently reproduce step #1 to #8

@zhouguiheng commented on GitHub (Jan 8, 2025): I encountered the same issue, and had to do step 9.1 to bring the host back. I set up a new container from scratch for testing, and can consistently reproduce step #1 to #8

kerem commented

2026-02-26 07:35:19 +03:00

Author

Owner

@hans-holgersson commented on GitHub (Jan 9, 2025):

@zhouguiheng do you use version 2.11.1 or another?

@hans-holgersson commented on GitHub (Jan 9, 2025): @zhouguiheng do you use version 2.11.1 or another?

kerem commented

2026-02-26 07:35:19 +03:00

Author

Owner

@Wadera commented on GitHub (Jan 9, 2025):

I'm on v2.12.2 and still can reproduce the issue

@Wadera commented on GitHub (Jan 9, 2025): I'm on `v2.12.2` and still can reproduce the issue

kerem commented

2026-02-26 07:35:19 +03:00

Author

Owner

@zhouguiheng commented on GitHub (Jan 9, 2025):

@zhouguiheng do you use version 2.11.1 or another?

Both 2.12.1 and 2.12.2 (latest) have this issue

@zhouguiheng commented on GitHub (Jan 9, 2025): > @zhouguiheng do you use version 2.11.1 or another? Both 2.12.1 and 2.12.2 (latest) have this issue

kerem commented

2026-02-26 07:35:19 +03:00

Author

Owner

@hans-holgersson commented on GitHub (Jan 9, 2025):

great ...

@hans-holgersson commented on GitHub (Jan 9, 2025): great ...

kerem commented

2026-02-26 07:35:19 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Aug 4, 2025):

Issue is now considered stale. If you want to keep it open, please comment 👍

@github-actions[bot] commented on GitHub (Aug 4, 2025): Issue is now considered stale. If you want to keep it open, please comment :+1:

kerem referenced this issue

2026-02-26 08:31:06 +03:00

[PR #2376] Adding sign with google in NPM #3559

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#2376

No description provided.

Rows
Columns