[GH-ISSUE #3170] Ways to move letsencrypt storage to /data volume #2148

Closed
opened 2026-02-26 07:34:14 +03:00 by kerem · 3 comments
Owner

Originally created by @iBobik on GitHub (Aug 30, 2023).
Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/3170

Hello, I create addon for Home Assistant OS which are just Docker image with some integration around.

For it I need to have all persistent data stored only in /data, other volumes will not survive recreate.

But there is an issue with /etc/letsencrypt - it is volume, so I cannot create symlink for it in my image (using your image as base).

Describe the solution you'd like
I would like to remove /etc/letsencrypt from VOLUME in the Dockerfile.
github.com/NginxProxyManager/nginx-proxy-manager@fa851b61da/docker/Dockerfile (L54)

Or have the directory configurable, but this seems more work.

Describe alternatives you've considered
There is option to not use this image as a base, but copy&paste its content to my Dockerfile, but this will be maintenance hell.

Thank you for help. I can do PR if you confirm the solution.

Originally created by @iBobik on GitHub (Aug 30, 2023). Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/3170 Hello, I create addon for Home Assistant OS which are just Docker image with some integration around. For it I need to have all persistent data stored only in /data, other volumes will not survive recreate. But there is an issue with /etc/letsencrypt - it is volume, so I cannot create symlink for it in my image (using your image as base). **Describe the solution you'd like** I would like to remove /etc/letsencrypt from VOLUME in the Dockerfile. https://github.com/NginxProxyManager/nginx-proxy-manager/blob/fa851b61da3fe3726d1a04c25e69d36e79edea2d/docker/Dockerfile#L54 Or have the directory configurable, but this seems more work. **Describe alternatives you've considered** There is option to not use this image as a base, but copy&paste its content to my Dockerfile, but this will be maintenance hell. Thank you for help. I can do PR if you confirm the solution.
kerem 2026-02-26 07:34:14 +03:00
Author
Owner

@iBobik commented on GitHub (Oct 14, 2023):

@jc21 are you ok with it? Can I prepare PR?

<!-- gh-comment-id:1763156807 --> @iBobik commented on GitHub (Oct 14, 2023): @jc21 are you ok with it? Can I prepare PR?
Author
Owner

@jc21 commented on GitHub (Nov 22, 2023):

It should be ok, since all the documentation says that users should mount this folder. The only time it might cause issues is if someone doesn't mount it and then upgrades to a new image where the volume will not be used and their certs will be gone. Might need to be a minor release required for this change.

<!-- gh-comment-id:1821889988 --> @jc21 commented on GitHub (Nov 22, 2023): It should be ok, since all the documentation says that users should mount this folder. The only time it might cause issues is if someone doesn't mount it and then upgrades to a new image where the volume will not be used and their certs will be gone. Might need to be a minor release required for this change.
Author
Owner

@iBobik commented on GitHub (Nov 22, 2023):

It should be ok, since all the documentation says that users should mount this folder. The only time it might cause issues is if someone doesn't mount it and then upgrades to a new image where the volume will not be used and their certs will be gone. Might need to be a minor release required for this change.

Thank you for reply. Would you mind checking my PR https://github.com/NginxProxyManager/nginx-proxy-manager/pull/3258?

<!-- gh-comment-id:1822124688 --> @iBobik commented on GitHub (Nov 22, 2023): > It should be ok, since all the documentation says that users should mount this folder. The only time it might cause issues is if someone doesn't mount it and then upgrades to a new image where the volume will not be used and their certs will be gone. Might need to be a minor release required for this change. Thank you for reply. Would you mind checking my PR https://github.com/NginxProxyManager/nginx-proxy-manager/pull/3258?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nginx-proxy-manager-NginxProxyManager#2148
No description provided.