mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-25 17:35:52 +03:00
[GH-ISSUE #2664] Increase max number of domains per vhost #1838
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#1838
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @fbatschi on GitHub (Mar 8, 2023).
Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/2664
Is your feature request related to a problem? Please describe.
Right now, each redirection host is limited to only have 15 domains (coming from the
maxOptionsin the render function of the forms. When you manage a big portfolio of domains this is quite limiting to have to setup identical vhosts, splitting up to 15 domains each, just because of the domain limit.Describe the solution you'd like
Let's Encrypt for instance supports up to 100 SAN in a certificate so I don't see why there should be a limit of 15 domains in a vhost in nginx proxy manager. Increase the limit to 100 - or make the number configurable either via env vars/docker-compose vars or configurable via backend what the limit of domains per vhost should be.
@phillf commented on GitHub (Mar 8, 2023):
Why not use a wildcard instead of individually naming every domain you want to serve? Just do *.example.com.
@fbatschi commented on GitHub (Mar 8, 2023):
its not about subdomains, but many individual 2nd level domain names (i am talking about hundreds of domains example1.com, example2.com, etc). right now i have to artificially split them into vhosts of 15 each.
With subdomains and using wildcards the same question would then arise. i would have to request wildcard Let's Encrypt certificates as well (which only works via dns) or also face the limit of 15 domains per form.
i am not sure what the thought behind this limit for form input was. is it a UI thing?
@phillf commented on GitHub (Mar 8, 2023):
@fbatschi, Was the original question posed a hypothetical or do you legitimately manage hundreds of domains? If yes, I honestly wonder if nginx proxy manager is the appropriate tool for your use case.
@fbatschi commented on GitHub (Mar 8, 2023):
Yes i actually manage several hundreds of domains that basically just do a simple http redirect. I used to edit nginx vhost configs file directly, but since somebody else should now be able to manage the redirects with a proper GUI, nginx proxy manager seems to be a great choice.
I will probably patch that
maxOptionsvalue myself and use my own docker build for it.Nevertheless i thought i would submit this feature request, since i don't really see where the motivation for this arbitrary limit of
15input values for all forms comes from. UX wise it would mean less duplicate settings if that limit would be higher.But i also understand, that only very few users would probably be impacted by it.
@nrgbistro commented on GitHub (Jun 3, 2023):
I have a use case for more than 15 subdomain items to one host. I'm using authentik to act as a proxy with authentication, so I want to point any subdomains I want to pass through authentik to the authentik host. Encountered this problem and thread while trying to add a 16th subdomain to authentik. For now I'm creating another entry to the same host, but as @fbatschi said this increases clutter in the UI. I would love the option to configure this seemingly arbitrary limit with a docker ENV.
@github-actions[bot] commented on GitHub (Jan 26, 2024):
Issue is now considered stale. If you want to keep it open, please comment 👍
@nrgbistro commented on GitHub (Jan 26, 2024):
👍
@github-actions[bot] commented on GitHub (Nov 13, 2024):
Issue is now considered stale. If you want to keep it open, please comment 👍
@phillf commented on GitHub (Nov 14, 2024):
👍
@aktso commented on GitHub (Jan 8, 2025):
I found values of a number of maxOptions are already 100 which appear to limit number of selected domain names. Just want to know whether the mentioned issue still exist.
@fbatschi commented on GitHub (Jan 22, 2025):
it seems indeed to be fixed (well, increased to 100 which would be sufficient for me for now).
closing this now.