mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-25 09:25:55 +03:00
[GH-ISSUE #2418] Internal error on renewing SSL certificate when all requests of proxy host are redirected #1697
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#1697
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @davhae on GitHub (Nov 22, 2022).
Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/2418
Checklist
jc21/nginx-proxy-manager:latestdocker image?Describe the bug
When using the Advanced NGINX Configuration of a proxy host to redirect all requests, renewal of certificates returns an internal error.
The configuration may look like this:
Nginx Proxy Manager Version
v2.9.18
Expected behavior
I don't really know if it is expected, but requests to .well-known should be handled by the reverse proxy.
Operating System
Ubuntu Jammy
@the1ts commented on GitHub (Nov 23, 2022):
Just asking, but does the problem domain have force-ssl enabled? There is a bug with this config, remove the force-ssl, manually renew and turn back on until the fixed is merged and released. The bug is because the current config forces the redirect to https before letsencrypt exception is processed so letsencrypt fails since it doesn't work over https. So check if its this bug or your rewrite that is causing the letsencrypt breakage.
@gnilebein commented on GitHub (Dec 12, 2022):
Is there an issue about the bug that I can subscribe to in order to get an info when it is fixed? I could not find one with the search.
@davhae commented on GitHub (Dec 12, 2022):
Disabling force-ssl for the only Redirection-Host using the certificate does not make it renewable.
On the other hand, temporarily removing the rewrite while force-ssl is activate results in a successful renew.
@gnilebein commented on GitHub (Dec 12, 2022):
There is an fix for the issue... Just need to be merged... i added the change to my docker container (FIX: https://github.com/NginxProxyManager/nginx-proxy-manager/pull/2038)
@davhae commented on GitHub (Dec 13, 2022):
Like i said it has nothing to do with force-ssl
@evelynhathaway commented on GitHub (Dec 26, 2022):
@davhae Maybe the issue is that
rewriteredirects before the NPM has a chance to respond to Let's Encrypt. What if you try wrapping yourrewritein alocationblock?Custom Nginx Configuration - Redirects ACME challenge (Before)
Custom Nginx Configuration - Responds to ACME challenge (After)
@github-actions[bot] commented on GitHub (Feb 4, 2024):
Issue is now considered stale. If you want to keep it open, please comment 👍
@github-actions[bot] commented on GitHub (Mar 21, 2025):
Issue was closed due to inactivity.