mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-26 09:55:51 +03:00
[GH-ISSUE #2254] wrong certificate being served after editing access list #1606
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#1606
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @watn3y on GitHub (Sep 6, 2022).
Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/2254
Checklist
jc21/nginx-proxy-manager:latestdocker image?Describe the bug
Sometimes, and I can't really pin down when, HTTPS sites added in NPM break. This can happen after a container-restart or during normal operation. When this happens, chrome reports either
ERR_HTTP2_PROTOCOL_ERRORorNET::ERR_CERT_AUTHORITY_INVALIDwith a certificate issued to and from localhost. Restarting the container or the host doesn't seem to fix this issue.Accessing the same URL over HTTP instead of HTTPS works perfectly fine.
The only reliable way to fix this seems to be to click Edit and then Save on each individual Proxy Host.
Nginx Proxy Manager Version
v2.9.18
Expected behavior
NPM directs the traffic normally
Screenshots

Operating System
debian 11
@qbiecom commented on GitHub (Sep 11, 2022):
I can replicate this if I edit the whitelist which is applied to my sites I get the 'localhost' certificate.
The steps detailed (clicking on each site to edit, the saving without changing anything) fixes it.
@timothevs commented on GitHub (Sep 26, 2022):
I too can replicate this - same steps as above. It is a pain to go through 30+ sites every few weeks.
@tsvane commented on GitHub (Oct 4, 2022):
Same problem here. Heres a dump of the config before and after reapplying settings through the WebUI.
Take a look at the sections around the "listen 443" settings (line 14-15) and "Let's Encrypt" (line 21-25), it seems that parts of the config is replaced by whitespaces.
Before:
After:
@rachelf42 commented on GitHub (Oct 7, 2022):
same problem here, same solution
i did notice that it happened when i saved a modification to my restricted access list and it only affected vhosts set to that access list
@outerregion commented on GitHub (Nov 12, 2022):
Adding this here as I had opened #2392 for the same issue. A short term, brute force work around is a cronjob to backup any .conf that contains letsencrypt every other minute and put it back every 5 minutes. It's messy, but it's keeping the ssl for now.
*/5 * * * * rsync -az /root/npm/ /root/docker/nginx-proxy-manager/data/nginx/proxy_host/ >/dev/null 2>&1
1-59/2 * * * * find . -type f -exec grep -lr "letsencrypt-acme-challenge" {} ; -exec cp -r {} /root/npm/ ; >/dev/null 2>&1
@derekoharrow commented on GitHub (Nov 21, 2022):
Just wanted to add a 'me too' to this - same problem, same workaround. Annoying when you have lots of proxy hosts that you manually have to edit and save (or disable/enable).
@tsvane commented on GitHub (Nov 23, 2022):
Automation of Edit+Save work around with Powershell
@tayfunyasar commented on GitHub (Dec 3, 2022):
I'm having same problem.
@peterge1998 commented on GitHub (Dec 18, 2022):
When I set everything up a month ago, everything was working fine. Today my site just shows this when accessing through firefox:

@qwrtty commented on GitHub (Dec 27, 2022):
I am also experiencing this issue on v2.9.19, every time I add a new user to an Access List. The workaround by @tsvane works, but I'm really looking forward to the day this is fixed.
@adrichman commented on GitHub (Dec 29, 2022):
can confirm I'm experiencing this consistently whenever there's a restarting of a backend service container that's being proxied to through npm