credentials contents to log #1333

New issue

Closed

opened 2026-02-26 07:30:32 +03:00 by kerem · 2 comments

kerem commented

2026-02-26 07:30:32 +03:00

Owner

Originally created by @olivergrahl on GitHub (Jan 25, 2022).
Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/1804

After setting up a Letsencrypt SSL certificate using a Google DNS challenge, the credentials provided as "Credentials File Content" get written to the log in plain text.

My suggestion would be to either not log this step at all, or at least strip the private_key from the log output.

I think it's risky enough to store the credentials in the db. Let's not also write it to the log. Thx for considering!

github.com/NginxProxyManager/nginx-proxy-manager@1f3ac7a9ec/backend/internal/certificate.js (L906)

Originally created by @olivergrahl on GitHub (Jan 25, 2022). Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/1804 After setting up a Letsencrypt SSL certificate using a Google DNS challenge, the credentials provided as "Credentials File Content" get written to the log in plain text. My suggestion would be to either not log this step at all, or at least strip the private_key from the log output. I think it's risky enough to store the credentials in the db. Let's not also write it to the log. Thx for considering! https://github.com/NginxProxyManager/nginx-proxy-manager/blob/1f3ac7a9ec80ec49a1c13ebcc46ab3f48ae026f4/backend/internal/certificate.js#L906

kerem

2026-02-26 07:30:32 +03:00

closed this issue
added the
enhancement

stale
labels

kerem commented

2026-02-26 07:30:32 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Feb 25, 2024):

Issue is now considered stale. If you want to keep it open, please comment 👍

@github-actions[bot] commented on GitHub (Feb 25, 2024): Issue is now considered stale. If you want to keep it open, please comment :+1:

kerem commented

2026-02-26 07:30:32 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Apr 10, 2025):

Issue was closed due to inactivity.

@github-actions[bot] commented on GitHub (Apr 10, 2025): Issue was closed due to inactivity.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/nginx-proxy-manager-NginxProxyManager#1333

No description provided.

Rows
Columns