mirror of
https://github.com/NginxProxyManager/nginx-proxy-manager.git
synced 2026-04-25 17:35:52 +03:00
[GH-ISSUE #1525] Issue with latest certbot implementation and previous certificates #1163
Labels
No labels
awaiting feedback
bug
cannot reproduce
dns provider request
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
need more info
no certbot plugin available
product-support
pull-request
question
stale
troll
upstream issue
v2
v2
v2
v3
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nginx-proxy-manager-NginxProxyManager#1163
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mora-phi on GitHub (Oct 27, 2021).
Original GitHub issue: https://github.com/NginxProxyManager/nginx-proxy-manager/issues/1525
Checklist
jc21/nginx-proxy-manager:latestdocker image?Describe the bug
Since latest update (2.9.10), some previous certbot implementation has been broken :
'Namespace' object has no attribute 'dns_ovh_credentials'
Indeed, the field in the letsencrypt/renewal/npm-2.conf (in my case there is a "-2" suffix) has no prefix and is now called "credentials" instead of "dns_ovh_credentials".
A manual updates solves this issue.
Nginx Proxy Manager Version
2.9.10
To Reproduce
Steps to reproduce the behavior:
The line in the certificate renewal should be something like :
dns_ovh_credentials = /etc/letsencrypt/credentials/credentials-2
Expected behavior
Correct certificate renewal.
If fields names in files have been modified, they should be upgraded when new NPM starts... Or a "Breaking warning" should be displayed on the release page.
Operating System
Linux alpine 5.10.61-0-lts #1-Alpine SMP Fri, 27 Aug 2021 05:29:55 +0000 x86_64 Linux
Docker version 20.10.7, build f0df35096d5f5e6b559b42c7fde6c65a2909f7c5
@chaptergy commented on GitHub (Nov 1, 2021):
The namespaces are deprecated in certbot for a while now and that's why they have been removed. It sounds like certbot is still on an old version in your container. Could you please run
inside your container to seen what version you have installed? If you don't have version
1.19or1.20please provide a list of other dns providers you are using, one of them could cause certbot to downgrade.@mora-phi commented on GitHub (Nov 3, 2021):
Hi,
If it has been deprecated a while it's weird I haven't had the problem before, because all my containers are automatically updated using watchtower...
I have now updated and my certbot version inside the container is "certbot 1.20.0"
I close the issue, as I have manually updated my credentials file to remove the prefix : I just wanted to open it in case it could help anyone else.
Thanks.