mirror of
https://github.com/netbootxyz/netboot.xyz.git
synced 2026-04-25 23:25:54 +03:00
[PR #413] [MERGED] Add versioning, only update boot files for rolling #847
Labels
No labels
Hacktoberfest
Hacktoberfest
bootloader
bsd
bug
confirmed
documentation
duplicate
enhancement
enhancement
enhancement
eol
experimental-merged
freebsd
help wanted
invalid
investigate
ipxe
linux
live-os
memdisk
menu
no-issue-activity
no-issue-activity
pull-request
released
todo
upstream
windows
windows
work-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/netboot.xyz#847
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netbootxyz/netboot.xyz/pull/413
Author: @thelamer
Created: 12/12/2019
Status: ✅ Merged
Merged: 12/12/2019
Merged by: @antonym
Base:
development← Head:versioning📝 Commits (1)
78eac80only run the update logic on the rolling .x series, tag the versioned builds to display in menu📊 Changes
4 files changed (+22 additions, -9 deletions)
View changed files
📝
roles/netbootxyz/defaults/main.yml(+1 -1)📝
roles/netbootxyz/templates/menu/menu.ipxe.j2(+4 -2)📝
script/build_release(+16 -5)📝
user_overrides.yml(+1 -1)📄 Description
So the basics of this is if the user is using a specific versioned boot medium ( self hosted users and people specifically looking for versioned endpoint ) we do not include the upgrade logic it is redundant as they are already pointed to a static endpoint but there is also no need for it. They will see this specific version in their menu when booting.
If the user downloads the standard rolling release looking at the latest endpoints they will be pinged for an upgrade if we do a major version change ( 2.x to 3.x ) signifying we have made a significant change to the boot medium files and need it's functionality for the new menu files.
Let me know if you have any questions.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.