[PR #227] [MERGED] Update utils.ipxe - label :testpr #723

New issue

Closed

opened 2026-02-27 14:53:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 14:53:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netbootxyz/netboot.xyz/pull/227
Author: @Firminator
Created: 3/17/2018
Status: ✅ Merged
Merged: 3/31/2018
Merged by: @antonym

Base: master ← Head: patch-3

📝 Commits (1)

13e4284 Update utils.ipxe

📊 Changes

1 file changed (+11 additions, -11 deletions)

View changed files

📝 src/utils.ipxe (+11 -11)

📄 Description

changes in testpr:

change in variable name for clarification: "github_hash" is now "github_branch_or_hash"
text edit: 'hash' is now 'commit hash'
text edit: 'User' or 'User Name' is now 'username'
other innocuous text changes

utils.ipxe refers to the 'main_menu' label in line 134 even though there's no main_menu label defined in utils.ipxe. Will this fail or is iPXE aware of the 'main_menu' label in file main.ipxe line 34?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbootxyz/netboot.xyz/pull/227 **Author:** [@Firminator](https://github.com/Firminator) **Created:** 3/17/2018 **Status:** ✅ Merged **Merged:** 3/31/2018 **Merged by:** [@antonym](https://github.com/antonym) **Base:** `master` ← **Head:** `patch-3` --- ### 📝 Commits (1) - [`13e4284`](https://github.com/netbootxyz/netboot.xyz/commit/13e42846bb71b74d5ec80d6fa4687c8f40357e26) Update utils.ipxe ### 📊 Changes **1 file changed** (+11 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/utils.ipxe` (+11 -11) </details> ### 📄 Description changes in testpr: * change in variable name for clarification: "github_hash" is now "github_branch_or_hash" * text edit: 'hash' is now 'commit hash' * text edit: 'User' or 'User Name' is now 'username' * other innocuous text changes utils.ipxe refers to the 'main_menu' label in line 134 even though there's no main_menu label defined in utils.ipxe. Will this fail or is iPXE aware of the 'main_menu' label in file main.ipxe line 34? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>