[PR #1638] [MERGED] fix(ipxe): fix filename checks #3022

New issue

Closed

opened 2026-03-01 18:42:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 18:42:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netbootxyz/netboot.xyz/pull/1638
Author: @jkoelker
Created: 6/16/2025
Status: ✅ Merged
Merged: 6/17/2025
Merged by: @antonym

Base: development ← Head: tftpmenu

📝 Commits (1)

7bc3e6b fix(ipxe): fix filename checks

📊 Changes

2 files changed (+16 additions, -1 deletions)

View changed files

📝 CHANGELOG.md (+7 -0)
📝 roles/netbootxyz/templates/disks/netboot.xyz.j2 (+9 -1)

📄 Description

The filename contains the full path to the file, usually the netboot assets are in / of a tftp server, so the check if its booted from the ipxe assets will always fail. Add an additional check prepended with / to allow the check to pass when booted from the root of a tftp server.

Also add loading of MAC- ipxe scripts with hypens in addition to raw, i.e. MAC-00-11-22-33-44-55.ipxe or MAC-001122334455.ipxe.

Fixes: #1097

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbootxyz/netboot.xyz/pull/1638 **Author:** [@jkoelker](https://github.com/jkoelker) **Created:** 6/16/2025 **Status:** ✅ Merged **Merged:** 6/17/2025 **Merged by:** [@antonym](https://github.com/antonym) **Base:** `development` ← **Head:** `tftpmenu` --- ### 📝 Commits (1) - [`7bc3e6b`](https://github.com/netbootxyz/netboot.xyz/commit/7bc3e6b61f6095a633ec5d9a2559dd9ed6a28939) fix(ipxe): fix filename checks ### 📊 Changes **2 files changed** (+16 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+7 -0) 📝 `roles/netbootxyz/templates/disks/netboot.xyz.j2` (+9 -1) </details> ### 📄 Description The `filename` contains the full path to the file, usually the netboot assets are in `/` of a tftp server, so the check if its booted from the ipxe assets will always fail. Add an additional check prepended with `/` to allow the check to pass when booted from the root of a tftp server. Also add loading of MAC- ipxe scripts with hypens in addition to raw, i.e. `MAC-00-11-22-33-44-55.ipxe` or `MAC-001122334455.ipxe`. Fixes: #1097 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 18:42:25 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/netboot.xyz#3022

No description provided.

Rows
Columns