[PR #1536] [MERGED] Moves win_base_url and rhel_base_url to local-vars.ipxe #2995

New issue

Closed

opened 2026-03-01 18:42:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 18:42:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netbootxyz/netboot.xyz/pull/1536
Author: @antonym
Created: 11/15/2024
Status: ✅ Merged
Merged: 11/15/2024
Merged by: @antonym

Base: development ← Head: local-vars

📝 Commits (1)

af23557 Moves win_base_url and rhel_base_url to local-vars.ipxe

📊 Changes

4 files changed (+9 additions, -11 deletions)

View changed files

📝 CHANGELOG.md (+5 -0)
📝 roles/netbootxyz/templates/local-vars.ipxe.j2 (+4 -0)
📝 roles/netbootxyz/templates/menu/boot.cfg.j2 (+0 -7)
📝 user_overrides.yml (+0 -4)

📄 Description

Moves win_base_url and rhel_base_url to local-vars.ipxe as they are locally defined variables by the user and are not defined for the hosted site.

Prevents override of variables by the loaded boot.cfg.

Closes https://github.com/netbootxyz/netboot.xyz/issues/1344

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbootxyz/netboot.xyz/pull/1536 **Author:** [@antonym](https://github.com/antonym) **Created:** 11/15/2024 **Status:** ✅ Merged **Merged:** 11/15/2024 **Merged by:** [@antonym](https://github.com/antonym) **Base:** `development` ← **Head:** `local-vars` --- ### 📝 Commits (1) - [`af23557`](https://github.com/netbootxyz/netboot.xyz/commit/af235571486fc708cccd9f176f999a378d4910ba) Moves win_base_url and rhel_base_url to local-vars.ipxe ### 📊 Changes **4 files changed** (+9 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+5 -0) 📝 `roles/netbootxyz/templates/local-vars.ipxe.j2` (+4 -0) 📝 `roles/netbootxyz/templates/menu/boot.cfg.j2` (+0 -7) 📝 `user_overrides.yml` (+0 -4) </details> ### 📄 Description Moves win_base_url and rhel_base_url to local-vars.ipxe as they are locally defined variables by the user and are not defined for the hosted site. Prevents override of variables by the loaded boot.cfg. Closes https://github.com/netbootxyz/netboot.xyz/issues/1344 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 18:42:19 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/netboot.xyz#2995

No description provided.

Rows
Columns