starred/netboot.xyz

Fork 0

mirror of https://github.com/netbootxyz/netboot.xyz.git synced 2026-04-25 23:25:54 +03:00

[GH-ISSUE #1097] tftpmenu not loaded if tftp filename has a path component #297

New issue

Closed

opened 2026-02-27 14:51:14 +03:00 by kerem · 6 comments

kerem commented

2026-02-27 14:51:14 +03:00

Owner

Originally created by @abh on GitHub (Mar 16, 2022).
Original GitHub issue: https://github.com/netbootxyz/netboot.xyz/issues/1097

I load ipxe over tftp from a path (ipxe/netboot.xyz.kpxe). If I'm not mistaken (which is very possible) that's what makes this line from netboot.xyz.j2 not match:

isset ${tftp-server} && iseq ${filename} {{ bootloader_filename }}.kpxe && goto tftpmenu ||

It's not clear to me what the iseq part is supposed to be accomplishing. I am guessing there are some filenames that shouldn't go to tftpmenu, but if so I'd suggest those should be called out rather than the opposite. (And if they shouldn't be going to tftpmenu, would they ever be running in a context with tftp-server set?).

I believe this section should be replaced with just a line like:

isset ${tftp-server} && goto tftpmenu || goto menu

(at least for my use case this fixed it so I can use MAC-[mac-address].ipxe).

Originally created by @abh on GitHub (Mar 16, 2022). Original GitHub issue: https://github.com/netbootxyz/netboot.xyz/issues/1097 I load ipxe over tftp from a path (`ipxe/netboot.xyz.kpxe`). If I'm not mistaken (which is very possible) that's what makes this line from `netboot.xyz.j2` not match: ``` isset ${tftp-server} && iseq ${filename} {{ bootloader_filename }}.kpxe && goto tftpmenu || ``` It's not clear to me what the `iseq` part is supposed to be accomplishing. I am guessing there are some filenames that shouldn't go to `tftpmenu`, but if so I'd suggest those should be called out rather than the opposite. (And if they shouldn't be going to `tftpmenu`, would they ever be running in a context with `tftp-server` set?). I believe this section should be replaced with just a line like: isset ${tftp-server} && goto tftpmenu || goto menu (at least for my use case this fixed it so I can use `MAC-[mac-address].ipxe`).

kerem

2026-02-27 14:51:14 +03:00

closed this issue
added the
bug
label

kerem commented

2026-02-27 14:51:15 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Apr 15, 2022):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions[bot] commented on GitHub (Apr 15, 2022): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

kerem commented

2026-02-27 14:51:15 +03:00

Author

Owner

@abh commented on GitHub (Apr 15, 2022):

I don't have additional information, but the issue was real.

@abh commented on GitHub (Apr 15, 2022): I don't have additional information, but the issue was real.

kerem commented

2026-02-27 14:51:15 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (May 16, 2022):

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions[bot] commented on GitHub (May 16, 2022): This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

kerem commented

2026-02-27 14:51:15 +03:00

Author

Owner

@abh commented on GitHub (May 16, 2022):

@antonym, am I misunderstanding how the code is supposed to work?

@abh commented on GitHub (May 16, 2022): @antonym, am I misunderstanding how the code is supposed to work?

kerem commented

2026-02-27 14:51:15 +03:00

Author

Owner

@kfsone commented on GitHub (Nov 13, 2023):

I think there's something missing in the self-hosting instructions. I think all the images are actually supposed to be in a single directory on the tftp server? At which point, I'm not sure what the web service is for... And it seems like docker networking has changed so that using the docker container no-longer has any value, it can't open a connection back for responses.

@kfsone commented on GitHub (Nov 13, 2023): I think there's something missing in the self-hosting instructions. I think all the images are actually supposed to be in a single directory on the tftp server? At which point, I'm not sure what the web service is for... And it seems like docker networking has changed so that using the docker container no-longer has any value, it can't open a connection back for responses.

kerem commented

2026-02-27 14:51:15 +03:00

Author

Owner

@kfsone commented on GitHub (Nov 13, 2023):

In the docker container, all of the images are in one folder.

@kfsone commented on GitHub (Nov 13, 2023): In the docker container, all of the images are in one folder.

kerem referenced this issue

2026-02-27 14:53:10 +03:00

[PR #297] [MERGED] Upgrade BlackArch to 2018.12.01 #765

kerem referenced this issue

2026-03-01 18:39:33 +03:00

[PR #297] [MERGED] Upgrade BlackArch to 2018.12.01 #2300

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/netboot.xyz#297

No description provided.

Rows
Columns