[PR #977] [MERGED] Switch to arch variable instead of buildarch #2787

New issue

Closed

opened 2026-03-01 18:41:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 18:41:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netbootxyz/netboot.xyz/pull/977
Author: @antonym
Created: 8/30/2021
Status: ✅ Merged
Merged: 8/30/2021
Merged by: @antonym

Base: development ← Head: arch_identifier

📝 Commits (1)

69687e6 Switch to arch variable instead of buildarch

📊 Changes

2 files changed (+10 additions, -11 deletions)

View changed files

📝 roles/netbootxyz/templates/menu/boot.cfg.j2 (+6 -6)
📝 roles/netbootxyz/templates/menu/menu.ipxe.j2 (+4 -5)

📄 Description

Per iPXE docs, buildarch can be unreliable for architecture
detection, so move our other check earlier and rely
on that for boot.cfg routing.

Have seen issues where tftp booting the image picked up
a 64-bit machine as a 32-bit machine on the bootarch
check and then identifying it with cpuid as a 64-bit machine.

This caused menus to be obscured initially for those machine
types.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbootxyz/netboot.xyz/pull/977 **Author:** [@antonym](https://github.com/antonym) **Created:** 8/30/2021 **Status:** ✅ Merged **Merged:** 8/30/2021 **Merged by:** [@antonym](https://github.com/antonym) **Base:** `development` ← **Head:** `arch_identifier` --- ### 📝 Commits (1) - [`69687e6`](https://github.com/netbootxyz/netboot.xyz/commit/69687e6f5cce26dfc930db1ebb8b8bcad1575aef) Switch to arch variable instead of buildarch ### 📊 Changes **2 files changed** (+10 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `roles/netbootxyz/templates/menu/boot.cfg.j2` (+6 -6) 📝 `roles/netbootxyz/templates/menu/menu.ipxe.j2` (+4 -5) </details> ### 📄 Description Per iPXE docs, buildarch can be unreliable for architecture detection, so move our other check earlier and rely on that for boot.cfg routing. Have seen issues where tftp booting the image picked up a 64-bit machine as a 32-bit machine on the bootarch check and then identifying it with cpuid as a 64-bit machine. This caused menus to be obscured initially for those machine types. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 18:41:29 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/netboot.xyz#2787

No description provided.

Rows
Columns