[PR #587] [MERGED] Fix utilities override #2529

New issue

Closed

opened 2026-03-01 18:40:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 18:40:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netbootxyz/netboot.xyz/pull/587
Author: @Enrico204
Created: 3/28/2020
Status: ✅ Merged
Merged: 3/31/2020
Merged by: @antonym

Base: development ← Head: fix-utilities-override

📝 Commits (2)

b9ddd24 Fix utilities override in menu generation (Ansible task)
205ddcd Update user_overrides.yml comments to document the new override method

📊 Changes

2 files changed (+25 additions, -8 deletions)

View changed files

📝 roles/netbootxyz/tasks/generate_menus.yml (+18 -6)
📝 user_overrides.yml (+7 -2)

📄 Description

This pull request fixes the override of the "utilities" section, as it was splitted in "EFI" and "PCBIOS" in main.yml (utilitiesefi and utilitiespcbios) but not in user_overrides.yml documentation, nor in tasks/generate_menus.yml (Ansible role netbootxyz).

Also, by following the documentation in user_overrides.yml comments (that says to create a utilities_override: section) we incur in an error during the Ansible role execution of the relative task (as utilities is now undefined).

This pull request fixes the role and update the documentation in user_overrides.yml

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbootxyz/netboot.xyz/pull/587 **Author:** [@Enrico204](https://github.com/Enrico204) **Created:** 3/28/2020 **Status:** ✅ Merged **Merged:** 3/31/2020 **Merged by:** [@antonym](https://github.com/antonym) **Base:** `development` ← **Head:** `fix-utilities-override` --- ### 📝 Commits (2) - [`b9ddd24`](https://github.com/netbootxyz/netboot.xyz/commit/b9ddd24e79e0dd30be14f2607d11300b50f033f0) Fix utilities override in menu generation (Ansible task) - [`205ddcd`](https://github.com/netbootxyz/netboot.xyz/commit/205ddcdbf9cdb6afa39a4075623e8cbb16bc6b5f) Update user_overrides.yml comments to document the new override method ### 📊 Changes **2 files changed** (+25 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `roles/netbootxyz/tasks/generate_menus.yml` (+18 -6) 📝 `user_overrides.yml` (+7 -2) </details> ### 📄 Description This pull request fixes the override of the "utilities" section, as it was splitted in "EFI" and "PCBIOS" in `main.yml` (`utilitiesefi` and `utilitiespcbios`) but not in `user_overrides.yml` documentation, nor in `tasks/generate_menus.yml` (Ansible role `netbootxyz`). Also, by following the documentation in `user_overrides.yml` comments (that says to create a `utilities_override:` section) we incur in an error during the Ansible role execution of the relative task (as `utilities` is now undefined). This pull request fixes the role and update the documentation in `user_overrides.yml` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 18:40:28 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/netboot.xyz#2529

No description provided.

Rows
Columns