[PR #515] [MERGED] Removes external image signature checking #2476

New issue

Closed

opened 2026-03-01 18:40:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 18:40:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netbootxyz/netboot.xyz/pull/515
Author: @antonym
Created: 1/12/2020
Status: ✅ Merged
Merged: 1/13/2020
Merged by: @thelamer

Base: development ← Head: image_sig_checking

📝 Commits (1)

bcbc90d Removes external image signature checking

📊 Changes

16 files changed (+12 additions, -120 deletions)

View changed files

📝 roles/netbootxyz/defaults/main.yml (+0 -1)
📝 roles/netbootxyz/templates/menu/alpinelinux.ipxe.j2 (+1 -10)
📝 roles/netbootxyz/templates/menu/archlinux.ipxe.j2 (+1 -1)
📝 roles/netbootxyz/templates/menu/boot.cfg.j2 (+0 -3)
📝 roles/netbootxyz/templates/menu/centos.ipxe.j2 (+1 -11)
📝 roles/netbootxyz/templates/menu/debian.ipxe.j2 (+1 -11)
📝 roles/netbootxyz/templates/menu/devuan.ipxe.j2 (+1 -11)
📝 roles/netbootxyz/templates/menu/fedora.ipxe.j2 (+1 -11)
📝 roles/netbootxyz/templates/menu/ipfire.ipxe.j2 (+1 -10)
📝 roles/netbootxyz/templates/menu/mageia.ipxe.j2 (+1 -10)
📝 roles/netbootxyz/templates/menu/menu.ipxe.j2 (+0 -7)
📝 roles/netbootxyz/templates/menu/opensuse.ipxe.j2 (+1 -11)
📝 roles/netbootxyz/templates/menu/ubuntu.ipxe.j2 (+1 -11)
📝 roles/netbootxyz/templates/menu/utils-efi.ipxe.j2 (+1 -1)
📝 roles/netbootxyz/templates/menu/utils-pcbios.ipxe.j2 (+1 -10)
📝 script/netbootxyz-overrides.yml (+0 -1)

📄 Description

Cleans up code and removes external OS signature checking code
as it's not very reliable and not currently being used.

Source signature checking will remain in place.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbootxyz/netboot.xyz/pull/515 **Author:** [@antonym](https://github.com/antonym) **Created:** 1/12/2020 **Status:** ✅ Merged **Merged:** 1/13/2020 **Merged by:** [@thelamer](https://github.com/thelamer) **Base:** `development` ← **Head:** `image_sig_checking` --- ### 📝 Commits (1) - [`bcbc90d`](https://github.com/netbootxyz/netboot.xyz/commit/bcbc90d51bab51761bc4d5412c58d66780b47e97) Removes external image signature checking ### 📊 Changes **16 files changed** (+12 additions, -120 deletions) <details> <summary>View changed files</summary> 📝 `roles/netbootxyz/defaults/main.yml` (+0 -1) 📝 `roles/netbootxyz/templates/menu/alpinelinux.ipxe.j2` (+1 -10) 📝 `roles/netbootxyz/templates/menu/archlinux.ipxe.j2` (+1 -1) 📝 `roles/netbootxyz/templates/menu/boot.cfg.j2` (+0 -3) 📝 `roles/netbootxyz/templates/menu/centos.ipxe.j2` (+1 -11) 📝 `roles/netbootxyz/templates/menu/debian.ipxe.j2` (+1 -11) 📝 `roles/netbootxyz/templates/menu/devuan.ipxe.j2` (+1 -11) 📝 `roles/netbootxyz/templates/menu/fedora.ipxe.j2` (+1 -11) 📝 `roles/netbootxyz/templates/menu/ipfire.ipxe.j2` (+1 -10) 📝 `roles/netbootxyz/templates/menu/mageia.ipxe.j2` (+1 -10) 📝 `roles/netbootxyz/templates/menu/menu.ipxe.j2` (+0 -7) 📝 `roles/netbootxyz/templates/menu/opensuse.ipxe.j2` (+1 -11) 📝 `roles/netbootxyz/templates/menu/ubuntu.ipxe.j2` (+1 -11) 📝 `roles/netbootxyz/templates/menu/utils-efi.ipxe.j2` (+1 -1) 📝 `roles/netbootxyz/templates/menu/utils-pcbios.ipxe.j2` (+1 -10) 📝 `script/netbootxyz-overrides.yml` (+0 -1) </details> ### 📄 Description Cleans up code and removes external OS signature checking code as it's not very reliable and not currently being used. Source signature checking will remain in place. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 18:40:14 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/netboot.xyz#2476

No description provided.

Rows
Columns