[PR #453] [MERGED] Exit ipxe script in index, move version check #2422

New issue

Closed

opened 2026-03-01 18:40:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 18:40:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netbootxyz/netboot.xyz/pull/453
Author: @antonym
Created: 12/27/2019
Status: ✅ Merged
Merged: 12/27/2019
Merged by: @antonym

Base: development ← Head: index_versions

📝 Commits (1)

cf95297 Exit ipxe script in index, move version check

📊 Changes

3 files changed (+3 additions, -2 deletions)

View changed files

📝 roles/netbootxyz/templates/index.html.j2 (+1 -0)
📝 roles/netbootxyz/templates/menu/about.ipxe.j2 (+0 -2)
📝 roles/netbootxyz/templates/menu/menu.ipxe.j2 (+2 -0)

📄 Description

Without exit on index, ipxe script continues to run and fails on html code. Exit properly so that local boot loads correctly.

Moves upstream version check to menu so that it's always available when menu is loaded.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netbootxyz/netboot.xyz/pull/453 **Author:** [@antonym](https://github.com/antonym) **Created:** 12/27/2019 **Status:** ✅ Merged **Merged:** 12/27/2019 **Merged by:** [@antonym](https://github.com/antonym) **Base:** `development` ← **Head:** `index_versions` --- ### 📝 Commits (1) - [`cf95297`](https://github.com/netbootxyz/netboot.xyz/commit/cf95297d4d6cef63e4cadcb0825f0163bda14d30) Exit ipxe script in index, move version check ### 📊 Changes **3 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `roles/netbootxyz/templates/index.html.j2` (+1 -0) 📝 `roles/netbootxyz/templates/menu/about.ipxe.j2` (+0 -2) 📝 `roles/netbootxyz/templates/menu/menu.ipxe.j2` (+2 -0) </details> ### 📄 Description Without exit on index, ipxe script continues to run and fails on html code. Exit properly so that local boot loads correctly. Moves upstream version check to menu so that it's always available when menu is loaded. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-01 18:40:01 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/netboot.xyz#2422

No description provided.

Rows
Columns