mirror of
https://github.com/netbootxyz/netboot.xyz.git
synced 2026-04-25 15:15:56 +03:00
[PR #1373] [MERGED] Update Talos PXE menu, platforms, and add custom_kernel_params #1418
Labels
No labels
Hacktoberfest
Hacktoberfest
bootloader
bsd
bug
confirmed
documentation
duplicate
enhancement
enhancement
enhancement
eol
experimental-merged
freebsd
help wanted
invalid
investigate
ipxe
linux
live-os
memdisk
menu
no-issue-activity
no-issue-activity
pull-request
released
todo
upstream
windows
windows
work-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/netboot.xyz#1418
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netbootxyz/netboot.xyz/pull/1373
Author: @goproslowyo
Created: 12/16/2023
Status: ✅ Merged
Merged: 12/16/2023
Merged by: @antonym
Base:
development← Head:development📝 Commits (2)
986ff68Remove references to very old Talos versions6195940Update Talos template, platforms, add custom args📊 Changes
3 files changed (+31 additions, -19 deletions)
View changed files
📝
endpoints.yml(+0 -14)📝
roles/netbootxyz/defaults/main.yml(+22 -3)📝
roles/netbootxyz/templates/menu/talos.ipxe.j2(+9 -2)📄 Description
The second commit in the PR cleans up the Talos.ipxe menu, adds a new argument called
custom_kernel_paramsthat can be used to modify the parameters passed to the Talos kernel specifically, and adds a number of new supported arguments for thetalos.platformvariable (and fixes some platform names).The other commit removes the old
talosandtalos-amd64entries fromendpoints.ymlsince they're very old and haven't been updated in quite a while in asset-mirror (since there are no longer any talos-related branches). I've created the required files in a branch in my own repo here but I am unsure how to open a PR to a branch that doesn't exist in the upstream repo. Anyway, you can review those two branches here and here and they should get updated Talos entries generated inendpoints.yml. If those branches are useful let me know how to proceed.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.