mirror of
https://github.com/netbootxyz/netboot.xyz.git
synced 2026-04-26 15:45:53 +03:00
[PR #1349] [MERGED] Add arm64 image generation and allow for independent image generation #1408
Labels
No labels
Hacktoberfest
Hacktoberfest
bootloader
bsd
bug
confirmed
documentation
duplicate
enhancement
enhancement
enhancement
eol
experimental-merged
freebsd
help wanted
invalid
investigate
ipxe
linux
live-os
memdisk
menu
no-issue-activity
no-issue-activity
pull-request
released
todo
upstream
windows
windows
work-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/netboot.xyz#1408
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netbootxyz/netboot.xyz/pull/1349
Author: @nickshanks347
Created: 11/29/2023
Status: ✅ Merged
Merged: 12/6/2023
Merged by: @antonym
Base:
development← Head:development📝 Commits (3)
821e8beallow independent generation arm64/multiarch images208847aadd arm64 image build1b16f72add efi dependency📊 Changes
2 files changed (+42 additions, -4 deletions)
View changed files
📝
roles/netbootxyz/tasks/generate_disks.yml(+1 -4)📝
roles/netbootxyz/tasks/generate_disks_hybrid.yml(+41 -0)📄 Description
This merge does two things:
ISO/IMG are only generated when
generate_disks_legacy,generate_disks_armandgenerate_disks_efiare set totrueas well asgenerate_disks_hybrid. I believe any image should be able to be generated independently without having to have all of them generated. The code looks at the variables set and addresses this issue by explicitly declaring dependenciesThe second change adds arm64 ISO/IMG generation. With an increasing number of desktops/SBCs using arm64, images for this architecture would be useful.
May be worth adding in separate images for legacy and EFI so image generation times can be cut down.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.