mirror of
https://github.com/netbootxyz/netboot.xyz.git
synced 2026-04-25 23:25:54 +03:00
[PR #977] [MERGED] Switch to arch variable instead of buildarch #1246
Labels
No labels
Hacktoberfest
Hacktoberfest
bootloader
bsd
bug
confirmed
documentation
duplicate
enhancement
enhancement
enhancement
eol
experimental-merged
freebsd
help wanted
invalid
investigate
ipxe
linux
live-os
memdisk
menu
no-issue-activity
no-issue-activity
pull-request
released
todo
upstream
windows
windows
work-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/netboot.xyz#1246
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/netbootxyz/netboot.xyz/pull/977
Author: @antonym
Created: 8/30/2021
Status: ✅ Merged
Merged: 8/30/2021
Merged by: @antonym
Base:
development← Head:arch_identifier📝 Commits (1)
69687e6Switch to arch variable instead of buildarch📊 Changes
2 files changed (+10 additions, -11 deletions)
View changed files
📝
roles/netbootxyz/templates/menu/boot.cfg.j2(+6 -6)📝
roles/netbootxyz/templates/menu/menu.ipxe.j2(+4 -5)📄 Description
Per iPXE docs, buildarch can be unreliable for architecture
detection, so move our other check earlier and rely
on that for boot.cfg routing.
Have seen issues where tftp booting the image picked up
a 64-bit machine as a 32-bit machine on the bootarch
check and then identifying it with cpuid as a 64-bit machine.
This caused menus to be obscured initially for those machine
types.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.