[GH-ISSUE #32] Enable dark mode in Docusaurus once #9

Closed
opened 2026-02-27 14:56:44 +03:00 by kerem · 9 comments
Owner

Originally created by @antonym on GitHub (Sep 29, 2021).
Original GitHub issue: https://github.com/netbootxyz/netboot.xyz-docs/issues/32

Originally assigned to: @version0chiro on GitHub.

Enable dark mode in Docusaurus theme, need to set changing of theme to flip back and forth from svg logo. Logic for css needs to be changed to identify mode and flip to these:

https://github.com/netbootxyz/netboot.xyz-docs/blob/master/static/img/nbxyz-logo-dark.svg

https://github.com/netbootxyz/netboot.xyz-docs/blob/master/static/img/nbxyz-logo.svg

Source file here:

https://github.com/netbootxyz/netboot.xyz-docs/blob/master/src/components/HomepageFeatures.js

Originally created by @antonym on GitHub (Sep 29, 2021). Original GitHub issue: https://github.com/netbootxyz/netboot.xyz-docs/issues/32 Originally assigned to: @version0chiro on GitHub. Enable dark mode in Docusaurus theme, need to set changing of theme to flip back and forth from svg logo. Logic for css needs to be changed to identify mode and flip to these: https://github.com/netbootxyz/netboot.xyz-docs/blob/master/static/img/nbxyz-logo-dark.svg https://github.com/netbootxyz/netboot.xyz-docs/blob/master/static/img/nbxyz-logo.svg Source file here: https://github.com/netbootxyz/netboot.xyz-docs/blob/master/src/components/HomepageFeatures.js
Author
Owner

@version0chiro commented on GitHub (Sep 29, 2021):

I would love to work on this issue, will implement this using state management 🙋‍♂️

<!-- gh-comment-id:930309169 --> @version0chiro commented on GitHub (Sep 29, 2021): I would love to work on this issue, will implement this using state management 🙋‍♂️
Author
Owner

@antonym commented on GitHub (Sep 29, 2021):

That'd be great... I haven't had time to dig into moving past the default layout other then setting new images and modifying the text, I was able to modify it but it seems like the default could handle dark and light mode better.

<!-- gh-comment-id:930316093 --> @antonym commented on GitHub (Sep 29, 2021): That'd be great... I haven't had time to dig into moving past the default layout other then setting new images and modifying the text, I was able to modify it but it seems like the default could handle dark and light mode better.
Author
Owner

@version0chiro commented on GitHub (Sep 29, 2021):

Cool, I think I can make it work but will be fine if I send a PR on the 1st? as it will be counted for hacktober only then? If its urgent I can do it now. I will make the changes asap, does that work out for you?

<!-- gh-comment-id:930325584 --> @version0chiro commented on GitHub (Sep 29, 2021): Cool, I think I can make it work but will be fine if I send a PR on the 1st? as it will be counted for hacktober only then? If its urgent I can do it now. I will make the changes asap, does that work out for you?
Author
Owner

@antonym commented on GitHub (Sep 29, 2021):

Yeah, I'll make sure we get it tagged and we can wait until Hacktoberfest starts to merge it so you can get credit for sure.

<!-- gh-comment-id:930331574 --> @antonym commented on GitHub (Sep 29, 2021): Yeah, I'll make sure we get it tagged and we can wait until Hacktoberfest starts to merge it so you can get credit for sure.
Author
Owner

@version0chiro commented on GitHub (Sep 29, 2021):

Thanks a lot, just to get back to it, this is the designed output?
image

<!-- gh-comment-id:930343627 --> @version0chiro commented on GitHub (Sep 29, 2021): Thanks a lot, just to get back to it, this is the designed output? ![image](https://user-images.githubusercontent.com/56084650/135311528-d5c65331-0d8b-4526-b8e3-70a7980de2ca.png)
Author
Owner

@antonym commented on GitHub (Sep 29, 2021):

Yep, looks great, the logos were just dark before but looks fixed now.

<!-- gh-comment-id:930353677 --> @antonym commented on GitHub (Sep 29, 2021): Yep, looks great, the logos were just dark before but looks fixed now.
Author
Owner

@version0chiro commented on GitHub (Oct 1, 2021):

Hey @antonym , its 12 am EST and hacktober has officially began, would be great if you can assign this to me and I will send in a PR ASAP

<!-- gh-comment-id:931898235 --> @version0chiro commented on GitHub (Oct 1, 2021): Hey @antonym , its 12 am EST and hacktober has officially began, would be great if you can assign this to me and I will send in a PR ASAP
Author
Owner

@version0chiro commented on GitHub (Oct 1, 2021):

Sent a PR at #36

<!-- gh-comment-id:931907956 --> @version0chiro commented on GitHub (Oct 1, 2021): Sent a PR at #36
Author
Owner

@antonym commented on GitHub (Oct 1, 2021):

Thanks again, I had to make one small tweak to the iPXE logo but it looks great!

<!-- gh-comment-id:931944062 --> @antonym commented on GitHub (Oct 1, 2021): Thanks again, I had to make one small tweak to the iPXE logo but it looks great!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/netboot.xyz-docs#9
No description provided.