mirror of
https://github.com/netbootxyz/netboot.xyz-docs.git
synced 2026-04-25 06:55:55 +03:00
[GH-ISSUE #32] Enable dark mode in Docusaurus once #180
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/netboot.xyz-docs#180
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @antonym on GitHub (Sep 29, 2021).
Original GitHub issue: https://github.com/netbootxyz/netboot.xyz-docs/issues/32
Originally assigned to: @version0chiro on GitHub.
Enable dark mode in Docusaurus theme, need to set changing of theme to flip back and forth from svg logo. Logic for css needs to be changed to identify mode and flip to these:
https://github.com/netbootxyz/netboot.xyz-docs/blob/master/static/img/nbxyz-logo-dark.svg
https://github.com/netbootxyz/netboot.xyz-docs/blob/master/static/img/nbxyz-logo.svg
Source file here:
https://github.com/netbootxyz/netboot.xyz-docs/blob/master/src/components/HomepageFeatures.js
@version0chiro commented on GitHub (Sep 29, 2021):
I would love to work on this issue, will implement this using state management 🙋♂️
@antonym commented on GitHub (Sep 29, 2021):
That'd be great... I haven't had time to dig into moving past the default layout other then setting new images and modifying the text, I was able to modify it but it seems like the default could handle dark and light mode better.
@version0chiro commented on GitHub (Sep 29, 2021):
Cool, I think I can make it work but will be fine if I send a PR on the 1st? as it will be counted for hacktober only then? If its urgent I can do it now. I will make the changes asap, does that work out for you?
@antonym commented on GitHub (Sep 29, 2021):
Yeah, I'll make sure we get it tagged and we can wait until Hacktoberfest starts to merge it so you can get credit for sure.
@version0chiro commented on GitHub (Sep 29, 2021):
Thanks a lot, just to get back to it, this is the designed output?
@antonym commented on GitHub (Sep 29, 2021):
Yep, looks great, the logos were just dark before but looks fixed now.
@version0chiro commented on GitHub (Oct 1, 2021):
Hey @antonym , its 12 am EST and hacktober has officially began, would be great if you can assign this to me and I will send in a PR ASAP
@version0chiro commented on GitHub (Oct 1, 2021):
Sent a PR at #36
@antonym commented on GitHub (Oct 1, 2021):
Thanks again, I had to make one small tweak to the iPXE logo but it looks great!