mirror of
https://github.com/hirschmann/nbfc.git
synced 2026-04-25 16:45:53 +03:00
[GH-ISSUE #704] Add variable to control temperature polling rate #620
Labels
No labels
Stale
bug
config
discussion
duplicate
enhancement
experimental
feature
help-wanted
info
invalid
invalid
pull-request
question
up-for-grabs
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nbfc-hirschmann#620
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Dainslaif on GitHub (Jun 6, 2019).
Original GitHub issue: https://github.com/hirschmann/nbfc/issues/704
Is your feature request related to a problem? Please describe.
The temperature polling rate is hard-set to 3 seconds (per comments at https://github.com/hirschmann/nbfc/issues/703), so it lags quite a bit behind my computer's actual temperature, letting it spike before it kicks in and turns on the fans.
Describe the solution you'd like
Add in a variable that lets the user define their temperature polling rate. This would set how often NBFC updates the temperature value it operates from.
Additional context
Probably should have a low max value (3 seconds?) for the sake of safety.
@hirschmann commented on GitHub (Jun 6, 2019):
The temperature polling rate is the same as the EC polling rate and can be set via config.
Only the UI update rate is fixed at 3 seconds. The UI update rate doesn't affect the functionality of the NBFC service at all.
@Dainslaif commented on GitHub (Jun 6, 2019):
Interesting, is there a reason they don't just both update at the same rate?
@hirschmann commented on GitHub (Jun 6, 2019):
I wanted to avoid putting too much load on the system, especially when multiple clients are running at the same time. Also the client currently has no way of querying the service's poll interval.
I consider pushing changes to the client instead of polling in the future, though.
@github-actions[bot] commented on GitHub (Dec 5, 2019):
This issue is stale because it has been open more than 180 days with no activity. If nobody comments within 7 days, this issue will be closed