mirror of
https://github.com/hirschmann/nbfc.git
synced 2026-04-25 16:45:53 +03:00
[GH-ISSUE #470] The service can be contacted from remote hosts (Linux) #424
Labels
No labels
Stale
bug
config
discussion
duplicate
enhancement
experimental
feature
help-wanted
info
invalid
invalid
pull-request
question
up-for-grabs
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nbfc-hirschmann#424
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jonremy on GitHub (Apr 17, 2018).
Original GitHub issue: https://github.com/hirschmann/nbfc/issues/470
The service is listening on all interfaces (
0.0.0.0:8523innetstat -plnet) and thus can potentially be contacted from remote hosts.Also it may be beneficial if the service was accessible by the root user only.
Potential cause
It seems that
localhostin WCF addresses cause the service to listen on all interfaces, as described here.Partial Fix
By changing the address to 127.0.0.1, the service only listen on the loopback interface (in IPv6 for some reason). As I don't know .NET, I'm unsure this is the best change to do.
Additionally the service is still accessible by any user on the host.
System
5.10.1.204.15.6-300.fc27.x86_64@hirschmann commented on GitHub (Apr 17, 2018):
Thank you for the bug report. I think your fix is a good solution to this problem.
The service is accessible to all users with intent. After all the goal of this project is to make it as easy as possible for the users to control their notebook's fans.
I know there might be scenarios where this is a problem. In such cases, you could deny the access via iptables:
@jonremy commented on GitHub (Apr 17, 2018):
All good. Thank you for this project and maintaining it !