[PR #685] [MERGED] New config for Lenovo ThinkPad L390 i7-8565U #1334

Closed
opened 2026-02-26 00:35:08 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hirschmann/nbfc/pull/685
Author: @bekliev
Created: 5/14/2019
Status: Merged
Merged: 6/5/2019
Merged by: @hirschmann

Base: masterHead: config-lenovo-thinkpad-l390-i7


📝 Commits (6)

  • 52c3e52 Config for Lenovo ThinkPad L390 i7-8565U
  • 5031e54 Update Lenovo ThinkPad L390 i7-8565U.xml
  • 91ba058 Fixing issue to pass last test
  • 5d2905e Fixing again - previous was not right (max is 100)
  • c1c52f0 Last fixing
  • fe83e82 Forgot to make changes (this is last for sure)

📊 Changes

1 file changed (+57 additions, -0 deletions)

View changed files

Configs/Lenovo ThinkPad L390 i7-8565U.xml (+57 -0)

📄 Description

Accordingly to this guideline for config files, I'm answering by their order:

  1. This config is based on Lenovo U41-70.xml config file, cause of write and reads I think. Any other of ThinkPad line configs didn't work for my laptop.
  2. Repeating: based on Lenovo U41-70.xml config.
  3. This config doesn't require any modifications - just dropdown -> find it in the list -> Press Apply => and it will work.

Changes to base config:

  1. Changed threshold of starting temperatures to be matched with system settings untill 68 degrees works as system fan set up. But from 68+ degrees fan set up to 85%, and after 90+ degrees set to 100%. Remark: system settings wasn't turn on the fan for even 85%, the max power was 72%.
  2. Set fan's Min speed to 255 and Max speed to 64 - to be 100% matched with Current fan speed indicator. I mean Target fan speed and Current fan speed is identical with these settings.
  3. Added CPU model to the config name, cause I thought it can cause different coolers - I don't know for sure.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hirschmann/nbfc/pull/685 **Author:** [@bekliev](https://github.com/bekliev) **Created:** 5/14/2019 **Status:** ✅ Merged **Merged:** 6/5/2019 **Merged by:** [@hirschmann](https://github.com/hirschmann) **Base:** `master` ← **Head:** `config-lenovo-thinkpad-l390-i7` --- ### 📝 Commits (6) - [`52c3e52`](https://github.com/hirschmann/nbfc/commit/52c3e52b27a02aa70cca2bd9e5db30dcde45516c) Config for Lenovo ThinkPad L390 i7-8565U - [`5031e54`](https://github.com/hirschmann/nbfc/commit/5031e54023d6d4cafcef258d3d50ef5c9992126a) Update Lenovo ThinkPad L390 i7-8565U.xml - [`91ba058`](https://github.com/hirschmann/nbfc/commit/91ba058f12f3d55596be1ab2fefea672962546e6) Fixing issue to pass last test - [`5d2905e`](https://github.com/hirschmann/nbfc/commit/5d2905e5d2569bba7fd2527e90e22a1d12fdff2f) Fixing again - previous was not right (max is 100) - [`c1c52f0`](https://github.com/hirschmann/nbfc/commit/c1c52f0ee3f525a45e01457dba855006c45fb660) Last fixing - [`fe83e82`](https://github.com/hirschmann/nbfc/commit/fe83e828bd35bd8715f42f3b199265c10e72c70f) Forgot to make changes (this is last for sure) ### 📊 Changes **1 file changed** (+57 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `Configs/Lenovo ThinkPad L390 i7-8565U.xml` (+57 -0) </details> ### 📄 Description Accordingly to [this guideline](https://github.com/hirschmann/nbfc/blob/master/CONTRIBUTING.md#configs) for config files, I'm answering by their order: 1. This config is based on **Lenovo U41-70.xml** config file, cause of write and reads I think. Any other of ThinkPad line configs didn't work for my laptop. 2. Repeating: based on **Lenovo U41-70.xml** config. 3. This config doesn't require any modifications - just dropdown -> find it in the list -> Press **Apply** => and it will work. Changes to base config: 1. Changed threshold of starting temperatures to be matched with system settings untill 68 degrees works as system fan set up. But from 68+ degrees fan set up to 85%, and after 90+ degrees set to 100%. Remark: system settings wasn't turn on the fan for even 85%, the max power was 72%. 2. Set fan's **Min speed** to 255 and **Max speed** to 64 - to be 100% matched with **Current fan speed** indicator. I mean **Target fan speed** and **Current fan speed** is identical with these settings. 3. Added CPU model to the config name, cause I thought it can cause different coolers - I don't know for sure. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 00:35:08 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nbfc-hirschmann#1334
No description provided.