mirror of
https://github.com/hirschmann/nbfc.git
synced 2026-04-26 00:56:01 +03:00
[PR #633] Add option to repeatedly output status information #1322
Labels
No labels
Stale
bug
config
discussion
duplicate
enhancement
experimental
feature
help-wanted
info
invalid
invalid
pull-request
question
up-for-grabs
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/nbfc-hirschmann#1322
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hirschmann/nbfc/pull/633
Author: @602p
Created: 2/5/2019
Status: 🔄 Open
Base:
beta← Head:master📝 Commits (7)
4a3d004Add Lenovo ThinkPad x220i config (#588)79d36edAdd Acer Predator G3-572 config (#586)e4299e3Fix reset value in Lenovo ThinkPad 13 config (#604)8b19604Add Asus ROG G752VS configuration (#610)4354594Add HP Laptop 14-cm0xxx config (#615)c3dd9dcImprove config for HP ProBook 4530s (#618)f83ac29Add option to repeatedly output status information📊 Changes
8 files changed (+516 additions, -6 deletions)
View changed files
➕
Configs/Acer Predator G3-572.xml(+242 -0)➕
Configs/Asus ROG G752VS.xml(+112 -0)➕
Configs/HP Laptop 14-cm0xxx.xml(+67 -0)📝
Configs/HP ProBook 4530s.xml(+29 -4)📝
Configs/Lenovo ThinkPad 13.xml(+2 -2)➕
Configs/Lenovo ThinkPad x220i.xml(+46 -0)📝
Core/NbfcCli/CommandLineOptions/StatusVerb.cs(+9 -0)📝
Core/NbfcCli/Program.cs(+9 -0)📄 Description
This patch introduces a
-poption to thestatusverb of the cli tool that causes the status to be repeatedly output. The rate is configurable as an optional argument to the parameter (measured in seconds, supporting float values.)The rationale behind this patch is that I like to have a display of the current (target) fan speed in my system bar, and the CPU overhead from repeated mono startup was a major contributor to load on an otherwise idle system. Keeping a copy of the cli tool running in the background avoids that. I use this as an i3blocks element by running
nbfc status -p 1 -f 0 | awk '/Target/ { printf("%3d\n", $5); system("") }'withinterval=persist.If this is merged, we should be sure to update the CLI examples page on the Wiki.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.