[PR #604] [MERGED] decimal <> hex value fix #1316

Closed
opened 2026-02-26 00:35:04 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hirschmann/nbfc/pull/604
Author: @karolzlot
Created: 12/14/2018
Status: Merged
Merged: 1/6/2019
Merged by: @hirschmann

Base: masterHead: patch-2


📝 Commits (1)

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 Configs/Lenovo ThinkPad 13.xml (+2 -2)

📄 Description

I see that my e580 seems to behave in the same way, and I think this is a bug:

Author of this config probably wanted to set 80 as hex not as decimal

on my device this is what happens on exit:
hex 80 = dec 128 => factory auto mode
hex 50 = dec 80 => full speed of fan

I think author of config should confirm this before merge


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hirschmann/nbfc/pull/604 **Author:** [@karolzlot](https://github.com/karolzlot) **Created:** 12/14/2018 **Status:** ✅ Merged **Merged:** 1/6/2019 **Merged by:** [@hirschmann](https://github.com/hirschmann) **Base:** `master` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`924224e`](https://github.com/hirschmann/nbfc/commit/924224ecc46cbb83a9034ca5f42c0b85fb6ac53a) decimal <> hex value fix ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Configs/Lenovo ThinkPad 13.xml` (+2 -2) </details> ### 📄 Description I see that my e580 seems to behave in the same way, and I think this is a bug: Author of this config probably wanted to set 80 as hex not as decimal on my device this is what happens on exit: hex 80 = dec 128 => factory auto mode hex 50 = dec 80 => full speed of fan I think author of config should confirm this before merge --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 00:35:04 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/nbfc-hirschmann#1316
No description provided.