[GH-ISSUE #1257] Improve, scrub or better describe the "recommend" function #1075

New issue

Closed

opened 2026-02-26 00:34:19 +03:00 by kerem · 1 comment

kerem commented

2026-02-26 00:34:19 +03:00

Owner

Originally created by @ciscam on GitHub (May 20, 2022).
Original GitHub issue: https://github.com/hirschmann/nbfc/issues/1257

Is your feature request related to a problem? Please describe.
Looking through the issues I found problem descriptions and even qualified-sounding replies that give me the strong impression, that very few users understand that nbfc config --recommend actually just compares the system-device-name to config file names. It could as well recommend a config for a 17" gaming notebook to a tablet user.
Before digging deeper I had the impression, and it seems to be intuitive to most if not all users of this software, that this recommend function compares available fans, temp sensors or something similar.

I claim that "Recommend configs that may work for your device" is a misleading and unnecessarily dangerous description of this function.

Describe the solution you'd like
Either improve the function to actually consider the available modules and only then recommend configs, with information about what actually was a match. Similarity of name, category or brand might be useful for sorting those actual recommendations.

Or improve the descriptions of this function to match its actual behavior. See this pull request to nbfc-linux for an example:
https://github.com/nbfc-linux/nbfc-linux/pull/41/files

I will gladly prepare this as a pull request, if you do not decide to..

..just scrub it altogether and rather instruct users to look for similar notebook models in the config directory. A string comparison won't be able to tell that a 'Dell Inspiron 17LOUDGAMING' is very much not similar to an 'HP Inspire 13 Cloud Working', or that the latter is probably similar to my system-product-name '81YM'.

Additional context
Additionally, what's up with the dictionary structure? Imagine there are 5 configs which fortunately are spelled similarly to the system-product-name and use the correct amount of fan configurations and specify the correct registers for the current device.
I don't speak C# but it looks like instead of getting recommended those five configs, the functions makes sure to recommend at most one correct config to the user, besides a bunch of incorrect ones:
github.com/hirschmann/nbfc@fc9fb97015/Core/StagWare.Configurations/FanControlConfigManager.cs (L108-L123)

Originally created by @ciscam on GitHub (May 20, 2022). Original GitHub issue: https://github.com/hirschmann/nbfc/issues/1257 **Is your feature request related to a problem? Please describe.** Looking through the issues I found problem descriptions and even qualified-sounding replies that give me the strong impression, that very few users understand that `nbfc config --recommend` actually just compares the system-device-name to config file names. It could as well recommend a config for a 17" gaming notebook to a tablet user. Before digging deeper I had the impression, and it seems to be intuitive to most if not all users of this software, that this recommend function compares available fans, temp sensors or something similar. I claim that "Recommend configs that may work for your device" is a misleading and unnecessarily dangerous description of this function. **Describe the solution you'd like** Either improve the function to actually consider the available modules and only then recommend configs, with information about what actually was a match. Similarity of name, category or brand might be useful for sorting those actual recommendations. Or improve the descriptions of this function to match its actual behavior. See this pull request to nbfc-linux for an example: https://github.com/nbfc-linux/nbfc-linux/pull/41/files I will gladly prepare this as a pull request, if you do not decide to.. ..just scrub it altogether and rather instruct users to look for similar notebook models in the config directory. A string comparison won't be able to tell that a 'Dell **Inspir**on 17**LOUD**GAM**ING**' is very much not similar to an 'HP **Inspir**e 13 C**loud** Work**ing**', or that the latter is probably similar to my system-product-name '81YM'. **Additional context** Additionally, what's up with the dictionary structure? Imagine there are 5 configs which fortunately are spelled similarly to the system-product-name and use the _correct_ amount of fan configurations and specify the _correct_ registers for the current device. I don't speak C# but it looks like instead of getting recommended those five configs, the functions makes sure to recommend _at most one_ correct config to the user, besides a bunch of incorrect ones: https://github.com/hirschmann/nbfc/blob/fc9fb970155607d9ebc994f9e99c8ee09121e628/Core/StagWare.Configurations/FanControlConfigManager.cs#L108-L123

kerem

2026-02-26 00:34:19 +03:00

closed this issue
added the
Stale
label

kerem commented

2026-02-26 00:34:19 +03:00

Author

Owner

@github-actions[bot] commented on GitHub (Nov 18, 2022):

This issue is stale because it has been open more than 180 days with no activity. If nobody comments within 7 days, this issue will be closed

@github-actions[bot] commented on GitHub (Nov 18, 2022): This issue is stale because it has been open more than 180 days with no activity. If nobody comments within 7 days, this issue will be closed