[PR #31] [MERGED] Trying to carefully improve the language on a common exception message #889

New issue

Closed

opened 2026-03-04 03:02:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 03:02:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Seldaek/monolog/pull/31
Author: @weaverryan
Created: 5/13/2011
Status: ✅ Merged
Merged: 5/16/2011
Merged by: @Seldaek

Base: master ← Head: stream_exception_language

📝 Commits (1)

d39b708 Trying to carefully improve the language on a common exception message

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/Monolog/Handler/StreamHandler.php (+1 -1)

📄 Description

Hey Jordi-

There may be a better way to handle this - I'm not sure if you can determine factually if a stream URL is in fact a file or not. But basically, if we use the word "stream", it's not going to be clear to everyone. And since this is probably the first thing a user will see when they load up their newly downloaded Symfony2 distribution, I want it to be as clear as possible.

Thanks!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Seldaek/monolog/pull/31 **Author:** [@weaverryan](https://github.com/weaverryan) **Created:** 5/13/2011 **Status:** ✅ Merged **Merged:** 5/16/2011 **Merged by:** [@Seldaek](https://github.com/Seldaek) **Base:** `master` ← **Head:** `stream_exception_language` --- ### 📝 Commits (1) - [`d39b708`](https://github.com/Seldaek/monolog/commit/d39b7084cd8052fcba096bef0d887e43d05194e0) Trying to carefully improve the language on a common exception message ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Monolog/Handler/StreamHandler.php` (+1 -1) </details> ### 📄 Description Hey Jordi- There may be a better way to handle this - I'm not sure if you can determine factually if a stream URL is in fact a file or not. But basically, if we use the word "stream", it's not going to be clear to everyone. And since this is probably the first thing a user will see when they load up their newly downloaded Symfony2 distribution, I want it to be as clear as possible. Thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>