[PR #8] [MERGED] Improvements #870

New issue

Closed

opened 2026-03-04 03:02:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 03:02:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Seldaek/monolog/pull/8
Author: @stof
Created: 4/6/2011
Status: ✅ Merged
Merged: 4/6/2011
Merged by: @Seldaek

Base: master ← Head: improvements

📝 Commits (2)

87332a3 Added phpdoc for all methods and added the typehint for the FormatterInterface
3cb3dbd Made the write method protected

📊 Changes

22 files changed (+363 additions, -163 deletions)

View changed files

📝 src/Monolog/Formatter/FormatterInterface.php (+7 -1)
📝 src/Monolog/Formatter/JsonFormatter.php (+5 -1)
📝 src/Monolog/Formatter/LineFormatter.php (+9 -1)
📝 src/Monolog/Handler/AbstractHandler.php (+52 -25)
📝 src/Monolog/Handler/BufferHandler.php (+7 -9)
📝 src/Monolog/Handler/FingersCrossedHandler.php (+5 -10)
📝 src/Monolog/Handler/HandlerInterface.php (+8 -4)
📝 src/Monolog/Handler/NullHandler.php (+8 -1)
📝 src/Monolog/Handler/RotatingFileHandler.php (+13 -12)
📝 src/Monolog/Handler/StreamHandler.php (+15 -15)
📝 src/Monolog/Handler/SyslogHandler.php (+18 -5)
📝 src/Monolog/Handler/TestHandler.php (+5 -1)
📝 src/Monolog/Logger.php (+125 -0)
📝 src/Monolog/Processor/WebProcessor.php (+9 -1)
📝 tests/Monolog/Handler/AbstractHandlerTest.php (+8 -19)
📝 tests/Monolog/Handler/BufferHandlerTest.php (+2 -13)
📝 tests/Monolog/Handler/FingersCrossedHandlerTest.php (+2 -13)
📝 tests/Monolog/Handler/NullHandlerTest.php (+2 -17)
📝 tests/Monolog/Handler/RotatingFileHandlerTest.php (+8 -4)
📝 tests/Monolog/Handler/StreamHandlerTest.php (+13 -11)

...and 2 more files

📄 Description

This adds phpdoc on all methods and makes the write method protected as discussed yesterday on IRC.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Seldaek/monolog/pull/8 **Author:** [@stof](https://github.com/stof) **Created:** 4/6/2011 **Status:** ✅ Merged **Merged:** 4/6/2011 **Merged by:** [@Seldaek](https://github.com/Seldaek) **Base:** `master` ← **Head:** `improvements` --- ### 📝 Commits (2) - [`87332a3`](https://github.com/Seldaek/monolog/commit/87332a3e4e5838c97c4e6a6cb65e0c5ddfe6da22) Added phpdoc for all methods and added the typehint for the FormatterInterface - [`3cb3dbd`](https://github.com/Seldaek/monolog/commit/3cb3dbdc8fdf72a22044c529b6f45994d42c4785) Made the write method protected ### 📊 Changes **22 files changed** (+363 additions, -163 deletions) <details> <summary>View changed files</summary> 📝 `src/Monolog/Formatter/FormatterInterface.php` (+7 -1) 📝 `src/Monolog/Formatter/JsonFormatter.php` (+5 -1) 📝 `src/Monolog/Formatter/LineFormatter.php` (+9 -1) 📝 `src/Monolog/Handler/AbstractHandler.php` (+52 -25) 📝 `src/Monolog/Handler/BufferHandler.php` (+7 -9) 📝 `src/Monolog/Handler/FingersCrossedHandler.php` (+5 -10) 📝 `src/Monolog/Handler/HandlerInterface.php` (+8 -4) 📝 `src/Monolog/Handler/NullHandler.php` (+8 -1) 📝 `src/Monolog/Handler/RotatingFileHandler.php` (+13 -12) 📝 `src/Monolog/Handler/StreamHandler.php` (+15 -15) 📝 `src/Monolog/Handler/SyslogHandler.php` (+18 -5) 📝 `src/Monolog/Handler/TestHandler.php` (+5 -1) 📝 `src/Monolog/Logger.php` (+125 -0) 📝 `src/Monolog/Processor/WebProcessor.php` (+9 -1) 📝 `tests/Monolog/Handler/AbstractHandlerTest.php` (+8 -19) 📝 `tests/Monolog/Handler/BufferHandlerTest.php` (+2 -13) 📝 `tests/Monolog/Handler/FingersCrossedHandlerTest.php` (+2 -13) 📝 `tests/Monolog/Handler/NullHandlerTest.php` (+2 -17) 📝 `tests/Monolog/Handler/RotatingFileHandlerTest.php` (+8 -4) 📝 `tests/Monolog/Handler/StreamHandlerTest.php` (+13 -11) _...and 2 more files_ </details> ### 📄 Description This adds phpdoc on all methods and makes the `write` method protected as discussed yesterday on IRC. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>