mirror of
https://github.com/Seldaek/monolog.git
synced 2026-04-26 16:15:49 +03:00
[GH-ISSUE #1951] Rename TestCase class to prevent import conflicts with PHPUnit's TestCase #842
Labels
No labels
Bug
Documentation
Feature
Needs Work
Support
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/monolog#842
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @staabm on GitHub (Mar 6, 2025).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/1951
Monolog version 3
Write your question here.
today I was stumbling over a problem of wrongly used
TestCaseclass because autocompletion liked monologs class more then the phpunit one.this remindet me of a similar issue we had in the past with PHPStan: https://github.com/phpstan/phpstan-src/pull/634
do you think monolog could make a similar move and deprecate+rename the monologs' TestCase class so autocompletion in popular IDEs won't accidentally add monologs TestCase class instead of e.g. PHPunits class?
I think most arguments why this is a good idea and actually the root cause is a phpstorm bug was already discussed in the linked PHPStan issue. I think a lot of people would have less problems when this class would be renamed, even though its totally fine because its in a dedicated namespace.
@staabm commented on GitHub (Mar 6, 2025):
just found a duplicate which already got closed: https://github.com/Seldaek/monolog/issues/1677
@Seldaek commented on GitHub (Mar 15, 2025):
Is the
@internalworkaround not working anymore?@Seldaek commented on GitHub (Mar 15, 2025):
I mean renaming to MonologTestCase or something would be fine I think, with the deprecated/alias one extending from it and having the
@internaltag. Do you want to PR this?@staabm commented on GitHub (Mar 15, 2025):
Sure