starred/monolog
1
0
Fork 0
mirror of https://github.com/Seldaek/monolog.git synced 2026-04-26 16:15:49 +03:00
Code Issues 31 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #1945] RotatingFileHandler.php There may be bugs #836

New issue
Closed
opened 2026-03-04 03:01:14 +03:00 by kerem · 2 comments
kerem commented 2026-03-04 03:01:14 +03:00
Owner
Copy link

Originally created by @song1024 on GitHub (Feb 7, 2025).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/1945

Monolog version 1|2|3?
3.8.1

Write your bug report here.

RotatingFileHandler.php

if ($this->nextRotation <= $record->datetime) { ...

Is the condition written backwards?
The framework I am using uses this component, but the logs cannot be deleted. By tracing the source code and reverse modifying the conditions here, the logs were immediately deleted

Originally created by @song1024 on GitHub (Feb 7, 2025). Original GitHub issue: https://github.com/Seldaek/monolog/issues/1945 Monolog version 1|2|3? 3.8.1 Write your bug report here. RotatingFileHandler.php if ($this->nextRotation <= $record->datetime) { ... Is the condition written backwards? The framework I am using uses this component, but the logs cannot be deleted. By tracing the source code and reverse modifying the conditions here, the logs were immediately deleted
kerem 2026-03-04 03:01:14 +03:00
  • closed this issue
  • added the
    Bug
         label
kerem commented 2026-03-04 03:01:17 +03:00
Author
Owner
Copy link

@stof commented on GitHub (Feb 7, 2025):

This condition looks right to me: we trigger a rotation if the record date is after the time for which the next rotation is scheduled

<!-- gh-comment-id:2642698672 --> @stof commented on GitHub (Feb 7, 2025): This condition looks right to me: we trigger a rotation if the record date is after the time for which the next rotation is scheduled
kerem commented 2026-03-04 03:01:17 +03:00
Author
Owner
Copy link

@song1024 commented on GitHub (Feb 7, 2025):

Thank you, it may be an internal error in my local framework.
It's not a monolog error.

<!-- gh-comment-id:2643293176 --> @song1024 commented on GitHub (Feb 7, 2025): Thank you, it may be an internal error in my local framework. It's not a monolog error.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
esfix
2.x
1.x
3.10.0
2.11.0
3.9.0
3.8.1
3.8.0
2.10.0
3.7.0
3.6.0
2.9.3
3.5.0
2.9.2
3.4.0
3.3.1
2.9.1
3.3.0
2.9.0
3.2.0
2.8.0
3.1.0
2.7.0
1.27.1
3.0.0
2.6.0
3.0.0-RC1
2.5.0
2.4.0
1.27.0
2.3.5
2.3.4
2.3.3
2.3.2
2.3.1
2.3.0
1.26.1
2.2.0
1.26.0
2.1.1
1.25.5
2.1.0
1.25.4
2.0.2
1.25.3
2.0.1
1.25.2
1.25.1
1.25.0
2.0.0
2.0.0-beta2
2.0.0-beta1
1.24.0
1.23.0
1.22.1
1.22.0
1.21.0
1.20.0
1.19.0
1.18.2
1.18.1
1.18.0
1.17.2
1.17.1
1.17.0
1.16.0
1.15.0
1.14.0
1.13.1
1.13.0
1.12.0
1.11.0
1.10.0
1.9.1
1.9.0
1.8.0
1.7.0
1.6.0
1.5.0
1.4.1
1.4.0
1.3.1
1.3.0
1.2.1
1.2.0
1.1.0
1.0.2
1.0.1
1.0.0
1.0.0-RC1
Labels
Clear labels   
Bug

   
Documentation

   
Feature

   
Needs Work

   
Support

   
pull-request

Mirrored from GitHub Pull Request

No labels
Bug
Documentation
Feature
Needs Work
Support
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/monolog#836
No description provided.