mirror of
https://github.com/Seldaek/monolog.git
synced 2026-04-26 08:05:53 +03:00
[GH-ISSUE #1838] LogglyHandler - incorrect records comparison. #784
Labels
No labels
Bug
Documentation
Feature
Needs Work
Support
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/monolog#784
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dimasvas on GitHub (Sep 20, 2023).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/1838
Monolog version 3.4.0
Loggly does not receive all logs. The reason is an incorrect records comparison in LogglyHandler.
Source reference
Now the code is:
return ($record->level >= $level);It looks like should be:
return ($record->level->value >= $level->value);We should compare values properties of records.
@omerimzali commented on GitHub (Sep 30, 2023):
Hi @dimasvas, I crated a pr for this one.
https://github.com/Seldaek/monolog/pull/1841
@dimasvas commented on GitHub (Oct 2, 2023):
Hi omerimzali! Thank you very much!!!!
I have just decorated the handler and created a temporary kludge until a new version of the monolog package with the fix will be released. Thank you again! Looking forward for new monolog fixes.