mirror of
https://github.com/Seldaek/monolog.git
synced 2026-04-26 16:15:49 +03:00
[GH-ISSUE #1795] SyslogUdpHandler autoclose option #761
Labels
No labels
Bug
Documentation
Feature
Needs Work
Support
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/monolog#761
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @boesing on GitHub (Mar 2, 2023).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/1795
Hey there,
we do have some longrunning processes using
pcntl_forkwhich do log stuff viaSyslogUdpHandlerto our syslog.Due to the fact that it is a longrunning process, the UDP socket is never closed and therefore stays open until the process is restarted.
I wonder if it would make sense to have an option available in the
SyslogUdpHandlerwhich allows projects to configure somesocketAutoCloseoption so that the socket is being closed after message is being sent.I am open for other suggestions as well (i.e. some
CloseAfterProcessHandlerwhich decorates another processor).Thanks for your time.
Max
@Seldaek commented on GitHub (Mar 10, 2023):
If you're using Monolog 3, you can call $logger->close() as well as $logger->reset() in between "jobs" or whatever you have as a good point to do this where it makes sense, that would then be reopened whenever something needs to be written again.
github.com/Seldaek/monolog@d3d495b742/src/Monolog/Logger.php (L401-L416)@boesing commented on GitHub (Mar 10, 2023):
I do not have a strong need in closing all handlers. Some do not need to be closed as they do not keep ports open, that seems only being the case for the udp socket here 🤔
I have no handler doing http requests but I dont think that curl keeps TCP ports open which were used to send HTTP requests?
@Seldaek commented on GitHub (Mar 10, 2023):
You can also close the UDP handler directly of course, if that's more appropriate, but IMO closing/resetting everything between jobs in long running worker processes is a good approach.