mirror of
https://github.com/Seldaek/monolog.git
synced 2026-04-26 08:05:53 +03:00
[GH-ISSUE #1677] Rename TestCase class to something else to improve developer experience #716
Labels
No labels
Bug
Documentation
Feature
Needs Work
Support
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/monolog#716
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alexander-schranz on GitHub (May 25, 2022).
Original GitHub issue: https://github.com/Seldaek/monolog/issues/1677
I'm not sure why but PHPStorm begins to suggest me always the Monolog TestCase class instead of PHPUnit TestCase class. Was it in the past not part of the export? Not sure even strange that it begins now always be the first entry in the suggest list:
There was similar issue with PHPStan https://github.com/phpstan/phpstan-src/pull/634 where PHPStan decided to change the class for Developer Experience, maybe we can do the same here. Sadly it seems I'm little bit late as 3.0 was released shortly :/. But maybe we can already do some changes for a future 4.0 🤔.
@stof commented on GitHub (May 25, 2022):
It is part of the package since 2.0
@alexander-schranz commented on GitHub (May 30, 2022):
I see maybe was locked to monolog 1 until yet 🤔
@Seldaek commented on GitHub (Jun 8, 2022):
Yeah I can see this sucks, but it seems more like a PHPStorm issue than something that can be fixed here.. Tons of packages expose a TestCase class/file, it should really prefer the PHPUnit one unless you have a local TestCase class in the project itself (which it already seems to prefer unless I'm mistaken).
Only thing I can think of is to mark it internal, which may help PHPStorm, but will also nag anyone relying on the class in third party extensions, which may be an ok trade-off. Can you try if adding
@internalfixes it for you?@mfn commented on GitHub (Jun 9, 2022):
@alexander-schranz maybe also try on https://youtrack.jetbrains.com/ directly on the PhpStorm team
@alexander-schranz commented on GitHub (Jun 9, 2022):
@Seldaek Yes the
@internalwould work:@mfn created an issue here: https://youtrack.jetbrains.com/issue/WI-67050/Auto-Completion-should-prefer-PHPUnit-TestCase-over-other-third-party-TestCase-classes
@stof commented on GitHub (Jun 9, 2022):
I don't think tons of package expose it. Many package have one in their testsuite. But as of Monolog 2, it is part of the package itself, not of the testsuite (and so not excluded from the archive). I think most packages exposing a reusable base testcase give it a name describing it.
@alexander-schranz commented on GitHub (Jun 9, 2022):
@Seldaek Thank you!